From: phillbush <phillbush@cock.li>
Date: Thu, 17 Sep 2020 00:04:43 +0000 (-0300)
Subject: free stuff earlier, when they're no longer used
X-Git-Url: http://git.subgeniuskitty.com/xmenu/.git/commitdiff_plain/d3c213125090d49408c78d2c4a9200ec1575c187

free stuff earlier, when they're no longer used
---

diff --git a/xmenu.c b/xmenu.c
index 931d3fe..d557f6d 100644
--- a/xmenu.c
+++ b/xmenu.c
@@ -1015,16 +1015,21 @@ drawitems(struct Menu *menu)
 				             Convex, CoordModeOrigin);
 			}
 
-			/* draw icon */
-			if (item->file && !iflag)
+			/* try to load icon */
+			if (item->file && !iflag) {
 				item->icon = loadicon(item->file);
+				free(item->file);
+			}
 
+			/* draw icon if properly loaded */
 			if (item->icon) {
 				imlib_context_set_image(item->icon);
 				imlib_context_set_drawable(item->sel);
 				imlib_render_image_on_drawable(config.horzpadding, config.iconpadding);
 				imlib_context_set_drawable(item->unsel);
 				imlib_render_image_on_drawable(config.horzpadding, config.iconpadding);
+				imlib_context_set_image(item->icon);
+				imlib_free_image();
 			}
 		}
 	}
@@ -1316,13 +1321,6 @@ cleanmenu(struct Menu *menu)
 		if (tmp->label != tmp->output)
 			free(tmp->label);
 		free(tmp->output);
-		if (tmp->file != NULL) {
-			free(tmp->file);
-			if (tmp->icon != NULL) {
-				imlib_context_set_image(tmp->icon);
-				imlib_free_image();
-			}
-		}
 		item = item->next;
 		free(tmp);
 	}