X-Git-Url: https://git.subgeniuskitty.com/xmenu/.git/blobdiff_plain/d2435fcd5f258e7dfc2993b1b2d0bfedf6ed883e..d584fba62674833135a9cb3eb9ec0f0e3fe96743:/xmenu.c

diff --git a/xmenu.c b/xmenu.c
index cc19921..2096e70 100644
--- a/xmenu.c
+++ b/xmenu.c
@@ -8,10 +8,12 @@
 #include <X11/Xresource.h>
 #include <X11/XKBlib.h>
 #include <X11/Xft/Xft.h>
+#include <Imlib2.h>
 
 #define PROGNAME "xmenu"
 #define ITEMPREV 0
 #define ITEMNEXT 1
+#define IMGPADDING 8
 
 /* macros */
 #define LEN(x) (sizeof (x) / sizeof (x[0]))
@@ -25,24 +27,18 @@ enum {ColorFG, ColorBG, ColorLast};
 struct DC {
 	XftColor normal[ColorLast];
 	XftColor selected[ColorLast];
-	XftColor decoration[ColorLast];
+	XftColor border;
+	XftColor separator;
 
-	Drawable d;
 	GC gc;
 	XftFont *font;
 };
 
 /* menu geometry structure */
 struct Geometry {
-	int itemb;      /* item border */
-	int itemw;      /* item width */
-	int itemh;      /* item height */
-	int border;     /* window border width */
-	int separator;  /* menu separator width */
-};
-
-/* screen geometry structure */
-struct ScreenGeometry {
+	int border;             /* window border width */
+	int separator;          /* menu separator width */
+	int itemw, itemh;       /* item width and height */
 	int cursx, cursy;       /* cursor position */
 	int screenw, screenh;   /* screen width and height */
 };
@@ -51,12 +47,14 @@ struct ScreenGeometry {
 struct Item {
 	char *label;            /* string to be drawed on menu */
 	char *output;           /* string to be outputed when item is clicked */
+	char *file;             /* filename of the icon */
 	int y;                  /* item y position relative to menu */
 	int h;                  /* item height */
 	size_t labellen;        /* strlen(label) */
 	struct Item *prev;      /* previous item */
 	struct Item *next;      /* next item */
 	struct Menu *submenu;   /* submenu spawned by clicking on item */
+	Imlib_Image icon;
 };
 
 /* menu structure */
@@ -72,57 +70,59 @@ struct Menu {
 	Window win;             /* menu window to map on the screen */
 };
 
-/* function declarations */
-static void getcolor(const char *s, XftColor *color);
+/* functions declarations */
 static void getresources(void);
+static void getcolor(const char *s, XftColor *color);
 static void setupdc(void);
-static void setupgeom(void);
-static void setupgrab(void);
-static struct Item *allocitem(const char *label, const char *output);
+static void calcgeom(struct Geometry *geom);
+static struct Item *allocitem(const char *label, const char *output, char *file);
 static struct Menu *allocmenu(struct Menu *parent, struct Item *list, unsigned level);
-static void getmenuitem(Window win, int y, struct Menu **menu_ret, struct Item **item_ret);
-static void drawmenu(void);
-static void calcscreengeom(void);
-static void calcmenu(struct Menu *menu);
-static void setcurrmenu(struct Menu *currmenu_new);
-static void parsestdin(void);
-static void run(void);
-static void freewindow(struct Menu *menu);
+static struct Menu *buildmenutree(unsigned level, const char *label, const char *output, char *file);
+static struct Menu *parsestdin(void);
+static void setupmenusize(struct Geometry *geom, struct Menu *menu);
+static void setupmenupos(struct Geometry *geom, struct Menu *menu);
+static void setupmenu(struct Geometry *geom, struct Menu *menu, XClassHint *classh);
+static void grabpointer(void);
+static void grabkeyboard(void);
+static struct Menu *getmenu(struct Menu *currmenu, Window win);
+static struct Item *getitem(struct Menu *menu, int y);
+static void mapmenu(struct Menu *currmenu);
+static void drawseparator(struct Menu *menu, struct Item *item);
+static void drawitem(struct Menu *menu, struct Item *item, XftColor *color);
+static void drawmenu(struct Menu *currmenu);
+static struct Item *itemcycle(struct Menu *currmenu, int direction);
+static void run(struct Menu *currmenu);
+static void freemenu(struct Menu *menu);
 static void cleanup(void);
 static void usage(void);
 
-/* X variables */
-static Colormap colormap;
+/* X stuff */
 static Display *dpy;
+static int screen;
 static Visual *visual;
 static Window rootwin;
-static int screen;
+static Colormap colormap;
 static struct DC dc;
+static Atom wmdelete;
 
-/* menu variables */
-static struct Menu *rootmenu = NULL;
-static struct Menu *currmenu = NULL;
-static char **menutitle;
-static int menutitlecount;
-
-/* geometry variables */
-static struct Geometry geom;
-static struct ScreenGeometry screengeom;
-
-/* flag variables */
-static Bool override_redirect = True;
+/* flags */
+static int wflag = 0;   /* whether to let the window manager control XMenu */
 
 #include "config.h"
 
+/* xmenu: generate menu from stdin and print selected entry to stdout */
 int
 main(int argc, char *argv[])
 {
+	struct Menu *rootmenu;
+	struct Geometry geom;
+	XClassHint classh;
 	int ch;
 
 	while ((ch = getopt(argc, argv, "w")) != -1) {
 		switch (ch) {
 		case 'w':
-			override_redirect = False;
+			wflag = 1;
 			break;
 		default:
 			usage();
@@ -132,8 +132,8 @@ main(int argc, char *argv[])
 	argc -= optind;
 	argv += optind;
 
-	menutitle = argv;
-	menutitlecount = argc;
+	if (argc > 1)
+		usage();
 
 	/* open connection to server and set X variables */
 	if ((dpy = XOpenDisplay(NULL)) == NULL)
@@ -142,30 +142,44 @@ main(int argc, char *argv[])
 	visual = DefaultVisual(dpy, screen);
 	rootwin = RootWindow(dpy, screen);
 	colormap = DefaultColormap(dpy, screen);
+	wmdelete=XInternAtom(dpy, "WM_DELETE_WINDOW", True);
+
+	/* imlib2 stuff */
+	imlib_set_cache_size(2048 * 1024);
+	imlib_context_set_dither(1);
+	imlib_context_set_display(dpy);
+	imlib_context_set_visual(visual);
+	imlib_context_set_colormap(colormap);
 
 	/* setup */
 	getresources();
 	setupdc();
-	setupgeom();
+	calcgeom(&geom);
 
-	/* generate menus and recalculate them */
-	parsestdin();
+	/* set window class */
+	classh.res_class = PROGNAME;
+	if (argc == 1)
+		classh.res_name = *argv;
+	else
+		classh.res_name = PROGNAME;
+
+	/* generate menus and set them up */
+	rootmenu = parsestdin();
 	if (rootmenu == NULL)
 		errx(1, "no menu generated");
-	calcscreengeom();
-	calcmenu(rootmenu);
+	setupmenu(&geom, rootmenu, &classh);
 
 	/* grab mouse and keyboard */
-	if (override_redirect)
-		setupgrab();
-
-	/* map root menu */
-	currmenu = rootmenu;
-	XMapWindow(dpy, rootmenu->win);
+	if (!wflag) {
+		grabpointer();
+		grabkeyboard();
+	}
 
 	/* run event loop */
-	run();
+	run(rootmenu);
 
+	/* freeing stuff */
+	freemenu(rootmenu);
 	cleanup();
 
 	return 0;
@@ -177,44 +191,44 @@ getresources(void)
 {
 	char *xrm;
 	long n;
+	char *type;
+	XrmDatabase xdb;
+	XrmValue xval;
 
 	XrmInitialize();
-	if ((xrm = XResourceManagerString(dpy))) {
-		char *type;
-		XrmDatabase xdb;
-		XrmValue xval;
-
-		xdb = XrmGetStringDatabase(xrm);
-
-		if (XrmGetResource(xdb, "xmenu.menuborder", "*", &type, &xval) == True)
-			if ((n = strtol(xval.addr, NULL, 10)) > 0)
-				menuborder = n;
-		if (XrmGetResource(xdb, "xmenu.separatorsize", "*", &type, &xval) == True)
-			if ((n = strtol(xval.addr, NULL, 10)) > 0)
-				separatorsize = n;
-		if (XrmGetResource(xdb, "xmenu.itemborder", "*", &type, &xval) == True)
-			if ((n = strtol(xval.addr, NULL, 10)) > 0)
-				itemborder = n;
-		if (XrmGetResource(xdb, "xmenu.width", "*", &type, &xval) == True)
-			if ((n = strtol(xval.addr, NULL, 10)) > 0)
-				width = n;
-		if (XrmGetResource(xdb, "xmenu.background", "*", &type, &xval) == True)
-			background = strdup(xval.addr);
-		if (XrmGetResource(xdb, "xmenu.foreground", "*", &type, &xval) == True)
-			foreground = strdup(xval.addr);
-		if (XrmGetResource(xdb, "xmenu.selbackground", "*", &type, &xval) == True)
-			selbackground = strdup(xval.addr);
-		if (XrmGetResource(xdb, "xmenu.selforeground", "*", &type, &xval) == True)
-			selforeground = strdup(xval.addr);
-		if (XrmGetResource(xdb, "xmenu.separator", "*", &type, &xval) == True)
-			separator = strdup(xval.addr);
-		if (XrmGetResource(xdb, "xmenu.border", "*", &type, &xval) == True)
-			border = strdup(xval.addr);
-		if (XrmGetResource(xdb, "xmenu.font", "*", &type, &xval) == True)
-			font = strdup(xval.addr);
-
-		XrmDestroyDatabase(xdb);
-	}
+	if ((xrm = XResourceManagerString(dpy)) == NULL)
+		return;
+
+	xdb = XrmGetStringDatabase(xrm);
+
+	if (XrmGetResource(xdb, "xmenu.borderWidth", "*", &type, &xval) == True)
+		if ((n = strtol(xval.addr, NULL, 10)) > 0)
+			border_pixels = n;
+	if (XrmGetResource(xdb, "xmenu.separatorWidth", "*", &type, &xval) == True)
+		if ((n = strtol(xval.addr, NULL, 10)) > 0)
+			separator_pixels = n;
+	if (XrmGetResource(xdb, "xmenu.padding", "*", &type, &xval) == True)
+		if ((n = strtol(xval.addr, NULL, 10)) > 0)
+			padding_pixels = n;
+	if (XrmGetResource(xdb, "xmenu.width", "*", &type, &xval) == True)
+		if ((n = strtol(xval.addr, NULL, 10)) > 0)
+			width_pixels = n;
+	if (XrmGetResource(xdb, "xmenu.background", "*", &type, &xval) == True)
+		background_color = strdup(xval.addr);
+	if (XrmGetResource(xdb, "xmenu.foreground", "*", &type, &xval) == True)
+		foreground_color = strdup(xval.addr);
+	if (XrmGetResource(xdb, "xmenu.selbackground", "*", &type, &xval) == True)
+		selbackground_color = strdup(xval.addr);
+	if (XrmGetResource(xdb, "xmenu.selforeground", "*", &type, &xval) == True)
+		selforeground_color = strdup(xval.addr);
+	if (XrmGetResource(xdb, "xmenu.separator", "*", &type, &xval) == True)
+		separator_color = strdup(xval.addr);
+	if (XrmGetResource(xdb, "xmenu.border", "*", &type, &xval) == True)
+		border_color = strdup(xval.addr);
+	if (XrmGetResource(xdb, "xmenu.font", "*", &type, &xval) == True)
+		font = strdup(xval.addr);
+
+	XrmDestroyDatabase(xdb);
 }
 
 /* get color from color string */
@@ -230,70 +244,74 @@ static void
 setupdc(void)
 {
 	/* get color pixels */
-	getcolor(background,    &dc.normal[ColorBG]);
-	getcolor(foreground,    &dc.normal[ColorFG]);
-	getcolor(selbackground, &dc.selected[ColorBG]);
-	getcolor(selforeground, &dc.selected[ColorFG]);
-	getcolor(separator,     &dc.decoration[ColorBG]);
-	getcolor(border,        &dc.decoration[ColorFG]);
+	getcolor(background_color,    &dc.normal[ColorBG]);
+	getcolor(foreground_color,    &dc.normal[ColorFG]);
+	getcolor(selbackground_color, &dc.selected[ColorBG]);
+	getcolor(selforeground_color, &dc.selected[ColorFG]);
+	getcolor(separator_color,     &dc.separator);
+	getcolor(border_color,        &dc.border);
 
 	/* try to get font */
 	if ((dc.font = XftFontOpenName(dpy, screen, font)) == NULL)
 		errx(1, "cannot load font");
 
-	/* create GC */
+	/* create common GC */
 	dc.gc = XCreateGC(dpy, rootwin, 0, NULL);
 }
 
-/* init menu geometry values */
+/* calculate menu and screen geometry */
 static void
-setupgeom(void)
+calcgeom(struct Geometry *geom)
 {
-	geom.itemb = itemborder;
-	geom.itemh = dc.font->height + itemborder * 2;
-	geom.itemw = width;
-	geom.border = menuborder;
-	geom.separator = separatorsize;
-}
+	Window w1, w2;  /* unused variables */
+	int a, b;       /* unused variables */
+	unsigned mask;  /* unused variable */
 
-/* grab pointer */
-static void
-setupgrab(void)
-{
-	if (XGrabPointer(dpy, rootwin, True, ButtonPressMask,
-	                 GrabModeAsync, GrabModeAsync, None,
-	                 None, CurrentTime) != GrabSuccess)
-		errx(1, "cannot grab pointer");
-	if (XGrabKeyboard(dpy, rootwin, True, GrabModeAsync,
-	                  GrabModeAsync, CurrentTime) != GrabSuccess)
-		errx(1, "cannot grab keyboard");
+	XQueryPointer(dpy, rootwin, &w1, &w2, &geom->cursx, &geom->cursy, &a, &b, &mask);
+	geom->screenw = DisplayWidth(dpy, screen);
+	geom->screenh = DisplayHeight(dpy, screen);
+	geom->itemh = dc.font->height + padding_pixels * 2;
+	geom->itemw = width_pixels;
+	geom->border = border_pixels;
+	geom->separator = separator_pixels;
 }
 
 /* allocate an item */
 static struct Item *
-allocitem(const char *label, const char *output)
+allocitem(const char *label, const char *output, char *file)
 {
 	struct Item *item;
 
 	if ((item = malloc(sizeof *item)) == NULL)
 		err(1, "malloc");
-	if (*label == '\0') {
+	if (label == NULL) {
 		item->label = NULL;
 		item->output = NULL;
 	} else {
 		if ((item->label = strdup(label)) == NULL)
 			err(1, "strdup");
-		if ((item->output = strdup(output)) == NULL)
+		if (label == output) {
+			item->output = item->label;
+		} else {
+			if ((item->output = strdup(output)) == NULL)
+				err(1, "strdup");
+		}
+	}
+	if (file == NULL) {
+		item->file = NULL;
+	} else {
+		if ((item->file = strdup(file)) == NULL)
 			err(1, "strdup");
 	}
 	item->y = 0;
-	item->h = item->label ? geom.itemh : geom.separator;
+	item->h = 0;
 	if (item->label == NULL)
 		item->labellen = 0;
 	else
 		item->labellen = strlen(item->label);
 	item->next = NULL;
 	item->submenu = NULL;
+	item->icon = NULL;
 
 	return item;
 }
@@ -311,205 +329,259 @@ allocmenu(struct Menu *parent, struct Item *list, unsigned level)
 	menu->list = list;
 	menu->caller = NULL;
 	menu->selected = NULL;
-	menu->w = geom.itemw;
-	menu->h = 0;    /* calculated by calcmenu() */
-	menu->x = 0;    /* calculated by calcmenu() */
-	menu->y = 0;    /* calculated by calcmenu() */
+	menu->w = 0;    /* calculated by setupmenu() */
+	menu->h = 0;    /* calculated by setupmenu() */
+	menu->x = 0;    /* calculated by setupmenu() */
+	menu->y = 0;    /* calculated by setupmenu() */
 	menu->level = level;
 
-	swa.override_redirect = override_redirect;
-	swa.background_pixel = dc.decoration[ColorBG].pixel;
-	swa.border_pixel = dc.decoration[ColorFG].pixel;
+	swa.override_redirect = (wflag) ? False : True;
+	swa.background_pixel = dc.normal[ColorBG].pixel;
+	swa.border_pixel = dc.border.pixel;
+	swa.save_under = True;  /* pop-up windows should save_under*/
 	swa.event_mask = ExposureMask | KeyPressMask | ButtonPressMask | ButtonReleaseMask
 	               | PointerMotionMask | LeaveWindowMask;
-	menu->win = XCreateWindow(dpy, rootwin, 0, 0, geom.itemw, geom.itemh, geom.border,
+	if (wflag)
+		swa.event_mask |= StructureNotifyMask;
+	menu->win = XCreateWindow(dpy, rootwin, 0, 0, 1, 1, 0,
 	                          CopyFromParent, CopyFromParent, CopyFromParent,
-	                          CWOverrideRedirect | CWBackPixel | CWBorderPixel | CWEventMask,
+	                          CWOverrideRedirect | CWBackPixel |
+	                          CWBorderPixel | CWEventMask | CWSaveUnder,
 	                          &swa);
 
+	XSetWMProtocols(dpy, menu->win, &wmdelete, 1);
+
 	return menu;
 }
 
-/* create menus and items from the stdin */
-static void
-parsestdin(void)
+/* build the menu tree */
+static struct Menu *
+buildmenutree(unsigned level, const char *label, const char *output, char *file)
 {
-	char *s, buf[BUFSIZ];
-	char *label, *output;
-	unsigned level = 0;
+	static struct Menu *prevmenu = NULL;    /* menu the previous item was added to */
+	static struct Menu *rootmenu = NULL;    /* menu to be returned */
+	struct Item *curritem = NULL;           /* item currently being read */
+	struct Item *item;                      /* dummy item for loops */
+	struct Menu *menu;                      /* dummy menu for loops */
 	unsigned i;
-	struct Item *curritem = NULL;   /* item currently being read */
- 	struct Menu *prevmenu = NULL;   /* menu the previous item was added to */
-	struct Item *item;              /* dummy item for for loops */
-	struct Menu *menu;              /* dummy menu for for loops */
- 	size_t count = 0;   /* number of items in the current menu */
-
-	while (fgets(buf, BUFSIZ, stdin) != NULL) {
-		level = 0;
-		s = buf;
-
-		while (*s == '\t') {
-			level++;
-			s++;
-		}
 
-		label = output = s;
-
-		while (*s != '\0' && *s != '\t' && *s != '\n')
-			s++;
-
-		while (*s == '\t')
-			*s++ = '\0';
+	/* create the item */
+	curritem = allocitem(label, output, file);
+
+	/* put the item in the menu tree */
+	if (prevmenu == NULL) {                 /* there is no menu yet */
+		 menu = allocmenu(NULL, curritem, level);
+		 rootmenu = menu;
+		 prevmenu = menu;
+		 curritem->prev = NULL;
+	} else if (level < prevmenu->level) {   /* item is continuation of a parent menu */
+		/* go up the menu tree until find the menu this item continues */
+		for (menu = prevmenu, i = level;
+			  menu != NULL && i != prevmenu->level;
+			  menu = menu->parent, i++)
+			;
+		if (menu == NULL)
+			errx(1, "reached NULL menu");
 
-		if (*s != '\0' && *s != '\n')
-			output = s;
+		/* find last item in the new menu */
+		for (item = menu->list; item->next != NULL; item = item->next)
+			;
 
-		while (*s != '\0' && *s != '\n')
-			s++;
+		prevmenu = menu;
+		item->next = curritem;
+		curritem->prev = item;
+	} else if (level == prevmenu->level) {  /* item is a continuation of current menu */
+		/* find last item in the previous menu */
+		for (item = prevmenu->list; item->next != NULL; item = item->next)
+			;
 
-		if (*s == '\n')
-			*s = '\0';
+		item->next = curritem;
+		curritem->prev = item;
+	} else if (level > prevmenu->level) {   /* item begins a new menu */
+		menu = allocmenu(prevmenu, curritem, level);
 
-		curritem = allocitem(label, output);
+		/* find last item in the previous menu */
+		for (item = prevmenu->list; item->next != NULL; item = item->next)
+			;
 
-		if (prevmenu == NULL) {                 /* there is no menu yet */
-			 menu = allocmenu(NULL, curritem, level);
-			 rootmenu = menu;
-			 prevmenu = menu;
-			 count = 1;
-			 curritem->prev = NULL;
-			 curritem->next = NULL;
-		} else if (level < prevmenu->level) {   /* item is continuation of a parent menu*/
-			for (menu = prevmenu, i = level;
-			      menu != NULL && i < prevmenu->level;
-			      menu = menu->parent, i++)
-				;
+		prevmenu = menu;
+		menu->caller = item;
+		item->submenu = menu;
+		curritem->prev = NULL;
+	}
 
-			if (menu == NULL)
-				errx(1, "reached NULL menu");
+	return rootmenu;
+}
 
-			for (item = menu->list; item->next != NULL; item = item->next)
-				;
+/* create menus and items from the stdin */
+static struct Menu *
+parsestdin(void)
+{
+	struct Menu *rootmenu;
+	char *s, buf[BUFSIZ];
+	char *file, *label, *output;
+	unsigned level = 0;
 
-			item->next = curritem;
+	rootmenu = NULL;
 
-			curritem->prev = item;
-			curritem->next = NULL;
+	while (fgets(buf, BUFSIZ, stdin) != NULL) {
+		/* get the indentation level */
+		level = strspn(buf, "\t");
+
+		/* get the label */
+		s = level + buf;
+		label = strtok(s, "\t\n");
+
+		/* get the filename */
+		file = NULL;
+		if (label != NULL && strncmp(label, "IMG:", 4) == 0) {
+			file = label + 4;
+			label = strtok(NULL, "\t\n");
+		}
 
-			prevmenu = menu;
-		} else if (level == prevmenu->level) {  /* item is a continuation of current menu */
-			for (item = prevmenu->list; item->next != NULL; item = item->next)
-				;
-			item->next = curritem;
+		/* get the output */
+		output = strtok(NULL, "\n");
+		if (output == NULL) {
+			output = label;
+		} else {
+			while (*output == '\t')
+				output++;
+		}
 
-			curritem->prev = item;
-			curritem->next = NULL;
+		rootmenu = buildmenutree(level, label, output, file);
+	}
 
-		} else if (level > prevmenu->level) {   /* item begins a new menu */
-			menu = allocmenu(prevmenu, curritem, level);
+	return rootmenu;
+}
 
-			for (item = prevmenu->list; item->next != NULL; item = item->next)
-				;
+/* load and scale icon */
+static Imlib_Image
+loadicon(const char *file, int size)
+{
+	Imlib_Image icon;
+	int width;
+	int height;
+	int imgsize;
 
-			item->submenu = menu;
-			menu->caller = item;
+	icon = imlib_load_image(file);
+	if (icon == NULL)
+		errx(1, "cannot load icon %s", file);
 
-			curritem->prev = NULL;
-			curritem->next = NULL;
+	imlib_context_set_image(icon);
 
-			prevmenu = menu;
-		}
-		count++;
-	}
-}
+	width = imlib_image_get_width();
+	height = imlib_image_get_height();
+	imgsize = MIN(width, height);
 
-/* calculate screen geometry */
-static void
-calcscreengeom(void)
-{
-	Window w1, w2;  /* unused variables */
-	int a, b;       /* unused variables */
-	unsigned mask;  /* unused variable */
+	icon = imlib_create_cropped_scaled_image(0, 0, imgsize, imgsize, size, size);
 
-	XQueryPointer(dpy, rootwin, &w1, &w2, &screengeom.cursx, &screengeom.cursy, &a, &b, &mask);
-	screengeom.screenw = DisplayWidth(dpy, screen);
-	screengeom.screenh = DisplayHeight(dpy, screen);
+	return icon;
 }
 
-/* recursivelly calculate height and position of the menus */
+/* setup the size of a menu and the position of its items */
 static void
-calcmenu(struct Menu *menu)
+setupmenusize(struct Geometry *geom, struct Menu *menu)
 {
-	static XClassHint classh = {PROGNAME, PROGNAME};
-	XWindowChanges changes;
-	XTextProperty textprop;
-	XSizeHints sizeh;
 	XGlyphInfo ext;
 	struct Item *item;
 	int labelwidth;
 
-	/* calculate items positions and menu width and height */
-	menu->w = geom.itemw;
+	menu->w = geom->itemw;
 	for (item = menu->list; item != NULL; item = item->next) {
 		item->y = menu->h;
+
 		if (item->label == NULL)   /* height for separator item */
-			menu->h += geom.separator;
+			item->h = geom->separator;
 		else
-			menu->h += geom.itemh;
+			item->h = geom->itemh;
+		menu->h += item->h;
 
+		/* get length of item->label rendered in the font */
 		XftTextExtentsUtf8(dpy, dc.font, (XftChar8 *)item->label,
 		                   item->labellen, &ext);
-		labelwidth = ext.xOff + dc.font->height * 2;
+		labelwidth = ext.xOff + dc.font->height * 2 + IMGPADDING * 2;
 		menu->w = MAX(menu->w, labelwidth);
+
+		/* create icon */
+		if (item->file != NULL)
+			item->icon = loadicon(item->file, dc.font->height);
 	}
+}
 
-	/* calculate menu's x and y positions */
+/* setup the position of a menu */
+static void
+setupmenupos(struct Geometry *g, struct Menu *menu)
+{
+	static struct Geometry *geom = NULL;
+	int width, height;
+
+	/*
+	 * Save the geometry so functions can call setupmenupos() without
+	 * having to know the geometry.
+	 */
+	if (g != NULL)
+		geom = g;
+
+	width = menu->w + geom->border * 2;
+	height = menu->h + geom->border * 2;
 	if (menu->parent == NULL) { /* if root menu, calculate in respect to cursor */
-		if (screengeom.screenw - screengeom.cursx >= menu->w)
-			menu->x = screengeom.cursx;
-		else if (screengeom.cursx > menu->w)
-			menu->x = screengeom.cursx - menu->w;
-
-		if (screengeom.screenh - screengeom.cursy >= menu->h)
-			menu->y = screengeom.cursy;
-		else if (screengeom.screenh > menu->h)
-			menu->y = screengeom.screenh - menu->h;
-
-		XStringListToTextProperty(menutitle, menutitlecount, &textprop);
+		if (geom->screenw - geom->cursx >= menu->w)
+			menu->x = geom->cursx;
+		else if (geom->cursx > width)
+			menu->x = geom->cursx - width;
+
+		if (geom->screenh - geom->cursy >= height)
+			menu->y = geom->cursy;
+		else if (geom->screenh > height)
+			menu->y = geom->screenh - height;
 	} else {                    /* else, calculate in respect to parent menu */
-
-		/* search for the item in parent menu that generates this menu */
-		for (item = menu->parent->list; item->submenu != menu; item = item->next)
-			;
-
-		if (screengeom.screenw - (menu->parent->x + menu->parent->w + geom.border) >= menu->w)
-			menu->x = menu->parent->x + menu->parent->w + geom.border;
-		else if (menu->parent->x > menu->w + geom.border)
-			menu->x = menu->parent->x - menu->w - geom.border;
-
-		if (screengeom.screenh - (item->y + menu->parent->y) > menu->h)
-			menu->y = item->y + menu->parent->y;
-		else if (screengeom.screenh - menu->parent->y > menu->h)
+		if (geom->screenw - (menu->parent->x + menu->parent->w + geom->border) >= width)
+			menu->x = menu->parent->x + menu->parent->w + geom->border;
+		else if (menu->parent->x > menu->w + geom->border)
+			menu->x = menu->parent->x - menu->w - geom->border;
+
+		if (geom->screenh - (menu->caller->y + menu->parent->y) > height)
+			menu->y = menu->caller->y + menu->parent->y;
+		else if (geom->screenh - menu->parent->y > height)
 			menu->y = menu->parent->y;
-		else if (screengeom.screenh > menu->h)
-			menu->y = screengeom.screenh - menu->h;
-
-		XStringListToTextProperty(&(menu->caller->output), 1, &textprop);
+		else if (geom->screenh > height)
+			menu->y = geom->screenh - height;
 	}
+}
+
+/* recursivelly setup menu configuration and its pixmap */
+static void
+setupmenu(struct Geometry *geom, struct Menu *menu, XClassHint *classh)
+{
+	struct Item *item;
+	XWindowChanges changes;
+	XSizeHints sizeh;
+	XTextProperty wintitle;
+
+	/* setup size and position of menus */
+	setupmenusize(geom, menu);
+	setupmenupos(geom, menu);
 
 	/* update menu geometry */
+	changes.border_width = geom->border;
 	changes.height = menu->h;
 	changes.width = menu->w;
 	changes.x = menu->x;
 	changes.y = menu->y;
-	XConfigureWindow(dpy, menu->win, CWWidth | CWHeight | CWX | CWY, &changes);
+	XConfigureWindow(dpy, menu->win, CWBorderWidth | CWWidth | CWHeight | CWX | CWY, &changes);
+
+	/* set window title (used if wflag is on) */
+	if (menu->parent == NULL) {
+		XStringListToTextProperty(&classh->res_name, 1, &wintitle);
+	} else {
+		XStringListToTextProperty(&menu->caller->output, 1, &wintitle);
+	}
 
 	/* set window manager hints */
 	sizeh.flags = PMaxSize | PMinSize;
 	sizeh.min_width = sizeh.max_width = menu->w;
 	sizeh.min_height = sizeh.max_height = menu->h;
-	XSetWMProperties(dpy, menu->win, &textprop, NULL, NULL, 0, &sizeh,
-	                 NULL, &classh);
+	XSetWMProperties(dpy, menu->win, &wintitle, NULL, NULL, 0, &sizeh, NULL, classh);
 
 	/* create pixmap and XftDraw */
 	menu->pixmap = XCreatePixmap(dpy, menu->win, menu->w, menu->h,
@@ -519,89 +591,184 @@ calcmenu(struct Menu *menu)
 	/* calculate positions of submenus */
 	for (item = menu->list; item != NULL; item = item->next) {
 		if (item->submenu != NULL)
-			calcmenu(item->submenu);
+			setupmenu(geom, item->submenu, classh);
 	}
 }
 
-/* get menu and item of given window and position */
+/* try to grab pointer, we may have to wait for another process to ungrab */
 static void
-getmenuitem(Window win, int y,
-            struct Menu **menu_ret, struct Item **item_ret)
+grabpointer(void)
 {
-	struct Menu *menu = NULL;
-	struct Item *item = NULL;
+	struct timespec ts = { .tv_sec = 0, .tv_nsec = 1000000  };
+	int i;
+
+	for (i = 0; i < 1000; i++) {
+		if (XGrabPointer(dpy, rootwin, True, ButtonPressMask,
+		                 GrabModeAsync, GrabModeAsync, None,
+		                 None, CurrentTime) == GrabSuccess)
+			return;
+		nanosleep(&ts, NULL);
+	}
+	errx(1, "cannot grab keyboard");
+}
 
-	for (menu = currmenu; menu != NULL; menu = menu->parent) {
-		if (menu->win == win) {
-			for (item = menu->list; item != NULL; item = item->next) {
-				if (y >= item->y && y <= item->y + item->h) {
-					goto done;
-				}
-			}
-		}
+/* try to grab keyboard, we may have to wait for another process to ungrab */
+static void
+grabkeyboard(void)
+{
+	struct timespec ts = { .tv_sec = 0, .tv_nsec = 1000000  };
+	int i;
+
+	for (i = 0; i < 1000; i++) {
+		if (XGrabKeyboard(dpy, rootwin, True, GrabModeAsync,
+		                  GrabModeAsync, CurrentTime) == GrabSuccess)
+			return;
+		nanosleep(&ts, NULL);
 	}
+	errx(1, "cannot grab keyboard");
+}
+
+/* get menu of given window */
+static struct Menu *
+getmenu(struct Menu *currmenu, Window win)
+{
+	struct Menu *menu;
+
+	for (menu = currmenu; menu != NULL; menu = menu->parent)
+		if (menu->win == win)
+			return menu;
+
+	return NULL;
+}
+
+/* get item of given menu and position */
+static struct Item *
+getitem(struct Menu *menu, int y)
+{
+	struct Item *item;
 
+	if (menu == NULL)
+		return NULL;
 
-done:
-	*menu_ret = menu;
-	*item_ret = item;
+	for (item = menu->list; item != NULL; item = item->next)
+		if (y >= item->y && y <= item->y + item->h)
+			return item;
+
+	return NULL;
 }
 
-/* set currentmenu to menu, umap previous menus and map current menu and its parents */
+/* umap previous menus and map current menu and its parents */
 static void
-setcurrmenu(struct Menu *currmenu_new)
+mapmenu(struct Menu *currmenu)
 {
+	static struct Menu *prevmenu = NULL;
 	struct Menu *menu, *menu_;
-	struct Item *item;
 	struct Menu *lcamenu;   /* lowest common ancestor menu */
 	unsigned minlevel;      /* level of the closest to root menu */
 	unsigned maxlevel;      /* level of the closest to root menu */
 
-	if (currmenu_new == currmenu)
+	/* do not remap current menu if it wasn't updated*/
+	if (prevmenu == currmenu)
 		return;
 
-	/* find lowest common ancestor menu */
-	lcamenu = rootmenu;
-	if (currmenu != NULL) {
-		minlevel = MIN(currmenu_new->level, currmenu->level);
-		maxlevel = MAX(currmenu_new->level, currmenu->level);
-		if (currmenu_new->level == maxlevel) {
-			menu = currmenu_new;
-			menu_ = currmenu;
-		} else {
-			menu = currmenu;
-			menu_ = currmenu_new;
-		}
-		while (menu->level > minlevel)
-			menu = menu->parent;
+	/* if this is the first time mapping, skip calculations */
+	if (prevmenu == NULL) {
+		XMapWindow(dpy, currmenu->win);
+		prevmenu = currmenu;
+		return;
+	}
 
-		while (menu != menu_) {
-			menu = menu->parent;
-			menu_ = menu_->parent;
-		}
-		lcamenu = menu;
+	/* find lowest common ancestor menu */
+	minlevel = MIN(currmenu->level, prevmenu->level);
+	maxlevel = MAX(currmenu->level, prevmenu->level);
+	if (currmenu->level == maxlevel) {
+		menu = currmenu;
+		menu_ = prevmenu;
+	} else {
+		menu = prevmenu;
+		menu_ = currmenu;
 	}
+	while (menu->level > minlevel)
+		menu = menu->parent;
+	while (menu != menu_) {
+		menu = menu->parent;
+		menu_ = menu_->parent;
+	}
+	lcamenu = menu;
 
 	/* unmap menus from currmenu (inclusive) until lcamenu (exclusive) */
-	for (menu = currmenu; menu != lcamenu; menu = menu->parent) {
+	for (menu = prevmenu; menu != lcamenu; menu = menu->parent) {
+		menu->selected = NULL;
 		XUnmapWindow(dpy, menu->win);
 	}
 
-	currmenu = currmenu_new;
-
 	/* map menus from currmenu (inclusive) until lcamenu (exclusive) */
-	item = NULL;
 	for (menu = currmenu; menu != lcamenu; menu = menu->parent) {
+
+		if (wflag) {
+			setupmenupos(NULL, menu);
+			XMoveWindow(dpy, menu->win, menu->x, menu->y);
+		}
+
 		XMapWindow(dpy, menu->win);
-		if (item != NULL)
-			menu->selected = item;
-		item = menu->caller;
+	}
+
+	prevmenu = currmenu;
+}
+
+/* draw separator item */
+static void
+drawseparator(struct Menu *menu, struct Item *item)
+{
+	int y;
+
+	y = item->y + item->h/2;
+
+	XSetForeground(dpy, dc.gc, dc.separator.pixel);
+	XDrawLine(dpy, menu->pixmap, dc.gc, 0, y, menu->w, y);
+}
+
+/* draw regular item */
+static void
+drawitem(struct Menu *menu, struct Item *item, XftColor *color)
+{
+	int x, y;
+
+	x = dc.font->height + IMGPADDING;
+	y = item->y + item->h/2 + dc.font->ascent/2 - 1;
+	XSetForeground(dpy, dc.gc, color[ColorFG].pixel);
+	XftDrawStringUtf8(menu->draw, &color[ColorFG], dc.font,
+                      x, y, item->label, item->labellen);
+
+	/* draw triangle, if item contains a submenu */
+	if (item->submenu != NULL) {
+		x = menu->w - dc.font->height/2 - IMGPADDING/2 - triangle_width/2 - 1;
+		y = item->y + item->h/2 - triangle_height/2 - 1;
+
+		XPoint triangle[] = {
+			{x, y},
+			{x + triangle_width, y + triangle_height/2},
+			{x, y + triangle_height},
+			{x, y}
+		};
+
+		XFillPolygon(dpy, menu->pixmap, dc.gc, triangle, LEN(triangle),
+		             Convex, CoordModeOrigin);
+	}
+
+	/* draw icon */
+	if (item->file != NULL) {
+		x = IMGPADDING / 2;
+		y = item->y + (item->h - dc.font->height) / 2;
+		imlib_context_set_drawable(menu->pixmap);
+		imlib_context_set_image(item->icon);
+		imlib_render_image_on_drawable(x, y);
 	}
 }
 
 /* draw items of the current menu and of its ancestors */
 static void
-drawmenu(void)
+drawmenu(struct Menu *currmenu)
 {
 	struct Menu *menu;
 	struct Item *item;
@@ -609,58 +776,32 @@ drawmenu(void)
 	for (menu = currmenu; menu != NULL; menu = menu->parent) {
 		for (item = menu->list; item != NULL; item = item->next) {
 			XftColor *color;
-			int labelx, labely;
 
 			/* determine item color */
-			if (item == menu->selected)
+			if (item == menu->selected && item->label != NULL)
 				color = dc.selected;
 			else
 				color = dc.normal;
 
-			/* continue if item is a separator */
-			if (item->label == NULL)
-				continue;
-
 			/* draw item box */
 			XSetForeground(dpy, dc.gc, color[ColorBG].pixel);
-			XDrawRectangle(dpy, menu->pixmap, dc.gc, 0, item->y,
-			               menu->w, item->h);
 			XFillRectangle(dpy, menu->pixmap, dc.gc, 0, item->y,
 			               menu->w, item->h);
 
-			/* draw item label */
-			labelx = 0 + dc.font->height;
-			labely = item->y + dc.font->height + geom.itemb / 2;
-			XSetForeground(dpy, dc.gc, color[ColorFG].pixel);
-			XftDrawStringUtf8(menu->draw, &color[ColorFG], dc.font,
-			                  labelx, labely, item->label,
-			                  item->labellen);
-
-			/* draw triangle, if item contains a submenu */
-			if (item->submenu != NULL) {
-				int trianglex = menu->w - dc.font->height + geom.itemb - 1;
-				int triangley = item->y + (3 * item->h)/8 -1;
-
-				XPoint triangle[] = {
-					{trianglex, triangley},
-					{trianglex + item->h/8 + 1, item->y + item->h/2},
-					{trianglex, triangley + item->h/4 + 2},
-					{trianglex, triangley}
-				};
-
-				XFillPolygon(dpy, menu->pixmap, dc.gc, triangle, LEN(triangle),
-				             Convex, CoordModeOrigin);
-			}
-
-			XCopyArea(dpy, menu->pixmap, menu->win, dc.gc, 0, item->y,
-			          menu->w, item->h, 0, item->y);
+			if (item->label == NULL)  /* item is a separator */
+				drawseparator(menu, item);
+			else                      /* item is a regular item */
+				drawitem(menu, item, color);
 		}
+
+		XCopyArea(dpy, menu->pixmap, menu->win, dc.gc, 0, 0,
+			      menu->w, menu->h, 0, 0);
 	}
 }
 
 /* cycle through the items; non-zero direction is next, zero is prev */
 static struct Item *
-itemcycle(int direction)
+itemcycle(struct Menu *currmenu, int direction)
 {
 	struct Item *item;
 	struct Item *lastitem;
@@ -701,7 +842,7 @@ itemcycle(int direction)
 
 /* run event loop */
 static void
-run(void)
+run(struct Menu *currmenu)
 {
 	struct Menu *menu;
 	struct Item *item;
@@ -709,55 +850,58 @@ run(void)
 	KeySym ksym;
 	XEvent ev;
 
+	mapmenu(currmenu);
+
 	while (!XNextEvent(dpy, &ev)) {
 		switch(ev.type) {
 		case Expose:
 			if (ev.xexpose.count == 0)
-				drawmenu();
+				drawmenu(currmenu);
 			break;
 		case MotionNotify:
-			getmenuitem(ev.xbutton.window, ev.xbutton.y, &menu, &item);
-			if (menu != NULL && item != NULL) {
-				if (previtem != item) {
-					if (item->submenu != NULL)
-						setcurrmenu(item->submenu);
-					else
-						setcurrmenu(menu);
-					previtem = item;
-					drawmenu();
-				} else if (menu->selected != item) {
-					menu->selected = item;
-					drawmenu();
-				}
+			menu = getmenu(currmenu, ev.xbutton.window);
+			item = getitem(menu, ev.xbutton.y);
+			if (menu == NULL || item == NULL || previtem == item)
+				break;
+			previtem = item;
+			menu->selected = item;
+			if (item->submenu != NULL) {
+				currmenu = item->submenu;
+				currmenu->selected = NULL;
+			} else {
+				currmenu = menu;
 			}
+			mapmenu(currmenu);
+			drawmenu(currmenu);
 			break;
 		case ButtonRelease:
-			getmenuitem(ev.xbutton.window, ev.xbutton.y, &menu, &item);
-			if (menu != NULL && item != NULL) {
-selectitem:
-				if (item->label == NULL)
-					break;  /* ignore separators */
-				if (item->submenu != NULL) {
-					setcurrmenu(item->submenu);
-				} else {
-					printf("%s\n", item->output);
-					return;
-				}
-				currmenu->selected = currmenu->list;
-				drawmenu();
+			menu = getmenu(currmenu, ev.xbutton.window);
+			item = getitem(menu, ev.xbutton.y);
+			if (menu == NULL || item == NULL)
 				break;
+selectitem:
+			if (item->label == NULL)
+				break;  /* ignore separators */
+			if (item->submenu != NULL) {
+				currmenu = item->submenu;
 			} else {
+				printf("%s\n", item->output);
 				return;
 			}
+			mapmenu(currmenu);
+			currmenu->selected = currmenu->list;
+			drawmenu(currmenu);
+			break;
 		case ButtonPress:
-			getmenuitem(ev.xbutton.window, ev.xbutton.y, &menu, &item);
-			if (menu == NULL || item == NULL)
+			menu = getmenu(currmenu, ev.xbutton.window);
+			if (menu == NULL)
 				return;
 			break;
 		case KeyPress:
 			ksym = XkbKeycodeToKeysym(dpy, ev.xkey.keycode, 0, 0);
 
-			if (ksym == XK_Escape && currmenu == rootmenu)
+			/* esc closes xmenu when current menu is the root menu */
+			if (ksym == XK_Escape && currmenu->parent == NULL)
 				return;
 
 			/* Shift-Tab = ISO_Left_Tab */
@@ -767,9 +911,9 @@ selectitem:
 			/* cycle through menu */
 			item = NULL;
 			if (ksym == XK_ISO_Left_Tab || ksym == XK_Up) {
-				item = itemcycle(ITEMPREV);
+				item = itemcycle(currmenu, ITEMPREV);
 			} else if (ksym == XK_Tab || ksym == XK_Down) {
-				item = itemcycle(ITEMNEXT);
+				item = itemcycle(currmenu, ITEMNEXT);
 			} else if ((ksym == XK_Return || ksym == XK_Right) &&
 			           currmenu->selected != NULL) {
 				item = currmenu->selected;
@@ -777,47 +921,82 @@ selectitem:
 			} else if ((ksym == XK_Escape || ksym == XK_Left) &&
 			           currmenu->parent != NULL) {
 				item = currmenu->parent->selected;
-				setcurrmenu(currmenu->parent);
+				currmenu = currmenu->parent;
+				mapmenu(currmenu);
 			} else
 				break;
 			currmenu->selected = item;
-			drawmenu();
+			drawmenu(currmenu);
 			break;
 		case LeaveNotify:
+			previtem = NULL;
 			currmenu->selected = NULL;
-			drawmenu();
+			drawmenu(currmenu);
+			break;
+		case ConfigureNotify:
+			menu = getmenu(currmenu, ev.xconfigure.window);
+			if (menu == NULL)
+				break;
+			menu->x = ev.xconfigure.x;
+			menu->y = ev.xconfigure.y;
+			break;
+		case ClientMessage:
+			/* user closed window */
+			menu = getmenu(currmenu, ev.xclient.window);
+			if (menu->parent == NULL)
+				return;     /* closing the root menu closes the program */
+			currmenu = menu->parent;
+			mapmenu(currmenu);
 			break;
 		}
 	}
 }
 
-/* recursivelly free a pixmap */
+/* recursivelly free pixmaps and destroy windows */
 static void
-freewindow(struct Menu *menu)
+freemenu(struct Menu *menu)
 {
 	struct Item *item;
+	struct Item *tmp;
 
-	for (item = menu->list; item != NULL; item = item->next)
+	item = menu->list;
+	while (item != NULL) {
 		if (item->submenu != NULL)
-			freewindow(item->submenu);
+			freemenu(item->submenu);
+		tmp = item;
+		if (tmp->label != tmp->output)
+			free(tmp->label);
+		free(tmp->output);
+		if (tmp->file != NULL) {
+			free(tmp->file);
+			if (tmp->icon != NULL) {
+				imlib_context_set_image(tmp->icon);
+				imlib_free_image();
+			}
+		}
+		item = item->next;
+		free(tmp);
+	}
 
 	XFreePixmap(dpy, menu->pixmap);
 	XftDrawDestroy(menu->draw);
 	XDestroyWindow(dpy, menu->win);
+	free(menu);
 }
 
 /* cleanup and exit */
 static void
 cleanup(void)
 {
-	freewindow(rootmenu);
+	XUngrabPointer(dpy, CurrentTime);
+	XUngrabKeyboard(dpy, CurrentTime);
 
 	XftColorFree(dpy, visual, colormap, &dc.normal[ColorBG]);
 	XftColorFree(dpy, visual, colormap, &dc.normal[ColorFG]);
 	XftColorFree(dpy, visual, colormap, &dc.selected[ColorBG]);
 	XftColorFree(dpy, visual, colormap, &dc.selected[ColorFG]);
-	XftColorFree(dpy, visual, colormap, &dc.decoration[ColorBG]);
-	XftColorFree(dpy, visual, colormap, &dc.decoration[ColorFG]);
+	XftColorFree(dpy, visual, colormap, &dc.separator);
+	XftColorFree(dpy, visual, colormap, &dc.border);
 
 	XFreeGC(dpy, dc.gc);
 	XCloseDisplay(dpy);
@@ -827,6 +1006,6 @@ cleanup(void)
 static void
 usage(void)
 {
-	(void)fprintf(stderr, "usage: xmenu [-w]\n");
+	(void)fprintf(stderr, "usage: xmenu [-w] [title]\n");
 	exit(1);
 }