projects / unix-history / blobdiff
? search:
summary | tags | clone url | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
prettiness police
[unix-history] / usr / src / usr.sbin / syslogd / syslogd.c
diff --git a/usr/src/usr.sbin/syslogd/syslogd.c b/usr/src/usr.sbin/syslogd/syslogd.c
index 83240e3..485c5d7 100644 (file)
--- a/usr/src/usr.sbin/syslogd/syslogd.c
+++ b/usr/src/usr.sbin/syslogd/syslogd.c
@@ -1,28 +1,18 @@
 /*
 /*
- * Copyright (c) 1983, 1988 Regents of the University of California.
- * All rights reserved.
+ * Copyright (c) 1983, 1988, 1993, 1994
+ *     The Regents of the University of California.  All rights reserved.
  *
  *
- * Redistribution and use in source and binary forms are permitted
- * provided that the above copyright notice and this paragraph are
- * duplicated in all such forms and that any documentation,
- * advertising materials, and other materials related to such
- * distribution and use acknowledge that the software was developed
- * by the University of California, Berkeley.  The name of the
- * University may not be used to endorse or promote products derived
- * from this software without specific prior written permission.
- * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR
- * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED
- * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
+ * %sccs.include.redist.c%
  */
 
 #ifndef lint
  */
 
 #ifndef lint
-char copyright[] =
-"@(#) Copyright (c) 1983, 1988 Regents of the University of California.\n\
- All rights reserved.\n";
+static char copyright[] =
+"@(#) Copyright (c) 1983, 1988, 1993, 1994\n\
+       The Regents of the University of California.  All rights reserved.\n";
 #endif /* not lint */
 
 #ifndef lint
 #endif /* not lint */
 
 #ifndef lint
-static char sccsid[] = "@(#)syslogd.c  5.28 (Berkeley) %G%";
+static char sccsid[] = "@(#)syslogd.c  8.3 (Berkeley) %G%";
 #endif /* not lint */
 
 /*
 #endif /* not lint */
 
 /*
@@ -53,46 +43,46 @@ static char sccsid[] = "@(#)syslogd.c       5.28 (Berkeley) %G%";
 #define DEFSPRI                (LOG_KERN|LOG_CRIT)
 #define TIMERINTVL     30              /* interval for checking flush, mark */
 
 #define DEFSPRI                (LOG_KERN|LOG_CRIT)
 #define TIMERINTVL     30              /* interval for checking flush, mark */
 
-#include <stdio.h>
-#include <utmp.h>
-#include <ctype.h>
-#include <strings.h>
-#include <setjmp.h>
-
-#include <sys/syslog.h>
 #include <sys/param.h>
 #include <sys/param.h>
-#include <sys/errno.h>
 #include <sys/ioctl.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
 #include <sys/socket.h>
 #include <sys/ioctl.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
 #include <sys/socket.h>
-#include <sys/file.h>
 #include <sys/msgbuf.h>
 #include <sys/uio.h>
 #include <sys/un.h>
 #include <sys/time.h>
 #include <sys/resource.h>
 #include <sys/msgbuf.h>
 #include <sys/uio.h>
 #include <sys/un.h>
 #include <sys/time.h>
 #include <sys/resource.h>
-#include <sys/signal.h>
 
 #include <netinet/in.h>
 #include <netdb.h>
 
 #include <netinet/in.h>
 #include <netdb.h>
+#include <arpa/inet.h>
+
+#include <ctype.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <setjmp.h>
+#include <signal.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+#include <utmp.h>
+#include "pathnames.h"
 
 
-#define        CTTY    "/dev/console"
-char   *LogName = "/dev/log";
-char   *ConfFile = "/etc/syslog.conf";
-char   *PidFile = "/etc/syslog.pid";
-char   ctty[] = CTTY;
+#define SYSLOG_NAMES
+#include <sys/syslog.h>
+
+char   *LogName = _PATH_LOG;
+char   *ConfFile = _PATH_LOGCONF;
+char   *PidFile = _PATH_LOGPID;
+char   ctty[] = _PATH_CONSOLE;
 
 #define FDMASK(fd)     (1 << (fd))
 
 #define        dprintf         if (Debug) printf
 
 
 #define FDMASK(fd)     (1 << (fd))
 
 #define        dprintf         if (Debug) printf
 
-#define UNAMESZ                8       /* length of a login name */
 #define MAXUNAMES      20      /* maximum number of user names */
 #define MAXUNAMES      20      /* maximum number of user names */
-#define MAXFNAME       200     /* max file pathname length */
-
-#define NOPRI          0x10    /* the "no priority" priority */
-#define        LOG_MARK        LOG_MAKEPRI(LOG_NFACILITIES, 0) /* mark "facility" */
 
 /*
  * Flags to logmsg().
 
 /*
  * Flags to logmsg().
@@ -115,12 +105,12 @@ struct filed {
        time_t  f_time;                 /* time this was last written */
        u_char  f_pmask[LOG_NFACILITIES+1];     /* priority mask */
        union {
        time_t  f_time;                 /* time this was last written */
        u_char  f_pmask[LOG_NFACILITIES+1];     /* priority mask */
        union {
-               char    f_uname[MAXUNAMES][UNAMESZ+1];
+               char    f_uname[MAXUNAMES][UT_NAMESIZE+1];
                struct {
                        char    f_hname[MAXHOSTNAMELEN+1];
                        struct sockaddr_in      f_addr;
                } f_forw;               /* forwarding address */
                struct {
                        char    f_hname[MAXHOSTNAMELEN+1];
                        struct sockaddr_in      f_addr;
                } f_forw;               /* forwarding address */
-               char    f_fname[MAXFNAME];
+               char    f_fname[MAXPATHLEN];
        } f_un;
        char    f_prevline[MAXSVLINE];          /* last message logged */
        char    f_lasttime[16];                 /* time of last occurrence */
        } f_un;
        char    f_prevline[MAXSVLINE];          /* last message logged */
        char    f_lasttime[16];                 /* time of last occurrence */
@@ -170,27 +160,35 @@ int       Initialized = 0;        /* set when we have initialized ourselves */
 int    MarkInterval = 20 * 60; /* interval between marks in seconds */
 int    MarkSeq = 0;            /* mark sequence number */
 
 int    MarkInterval = 20 * 60; /* interval between marks in seconds */
 int    MarkSeq = 0;            /* mark sequence number */
 
-extern int errno, sys_nerr;
-extern char *sys_errlist[];
-extern char *ctime(), *index(), *calloc();
-
+void   cfline __P((char *, struct filed *));
+char   *cvthname __P((struct sockaddr_in *));
+int    decode __P((const char *, CODE *));
+void   die __P((int));
+void   domark __P((int));
+void   fprintlog __P((struct filed *, int, char *));
+void   init __P((int));
+void   logerror __P((char *));
+void   logmsg __P((int, char *, char *, int));
+void   printline __P((char *, char *));
+void   printsys __P((char *));
+void   reapchild __P((int));
+char   *ttymsg __P((struct iovec *, int, char *, int));
+void   usage __P((void));
+void   wallmsg __P((struct filed *, struct iovec *));
+
+int
 main(argc, argv)
        int argc;
 main(argc, argv)
        int argc;
-       char **argv;
+       char *argv[];
 {
 {
-       register int i;
-       register char *p;
-       int funix, inetm, fklog, klogm, len;
+       int ch, funix, i, inetm, fklog, klogm, len;
        struct sockaddr_un sunx, fromunix;
        struct sockaddr_in sin, frominet;
        FILE *fp;
        struct sockaddr_un sunx, fromunix;
        struct sockaddr_in sin, frominet;
        FILE *fp;
-       int ch;
-       char line[MSG_BSIZE + 1];
-       extern int optind, die(), domark(), reapchild();
-       extern char *optarg;
+       char *p, line[MSG_BSIZE + 1];
 
        while ((ch = getopt(argc, argv, "df:m:p:")) != EOF)
 
        while ((ch = getopt(argc, argv, "df:m:p:")) != EOF)
-               switch((char)ch) {
+               switch(ch) {
                case 'd':               /* debug */
                        Debug++;
                        break;
                case 'd':               /* debug */
                        Debug++;
                        break;
@@ -207,45 +205,39 @@ main(argc, argv)
                default:
                        usage();
                }
                default:
                        usage();
                }
-       if (argc -= optind)
+       if ((argc -= optind) != 0)
                usage();
 
                usage();
 
-       if (!Debug) {
-               if (fork())
-                       exit(0);
-               for (i = 0; i < 10; i++)
-                       (void) close(i);
-               (void) open("/", 0);
-               (void) dup2(0, 1);
-               (void) dup2(0, 2);
-               untty();
-       } else
+       if (!Debug)
+               (void)daemon(0, 0);
+       else
                setlinebuf(stdout);
 
        consfile.f_type = F_CONSOLE;
                setlinebuf(stdout);
 
        consfile.f_type = F_CONSOLE;
-       (void) strcpy(consfile.f_un.f_fname, ctty);
-       (void) gethostname(LocalHostName, sizeof LocalHostName);
-       if (p = index(LocalHostName, '.')) {
+       (void)strcpy(consfile.f_un.f_fname, ctty);
+       (void)gethostname(LocalHostName, sizeof(LocalHostName));
+       if ((p = strchr(LocalHostName, '.')) != NULL) {
                *p++ = '\0';
                LocalDomain = p;
                *p++ = '\0';
                LocalDomain = p;
-       }
-       else
+       } else
                LocalDomain = "";
                LocalDomain = "";
-       (void) signal(SIGTERM, die);
-       (void) signal(SIGINT, Debug ? die : SIG_IGN);
-       (void) signal(SIGQUIT, Debug ? die : SIG_IGN);
-       (void) signal(SIGCHLD, reapchild);
-       (void) signal(SIGALRM, domark);
-       (void) alarm(TIMERINTVL);
-       (void) unlink(LogName);
-
-       bzero((char *)&sunx, sizeof(sunx));
+       (void)signal(SIGTERM, die);
+       (void)signal(SIGINT, Debug ? die : SIG_IGN);
+       (void)signal(SIGQUIT, Debug ? die : SIG_IGN);
+       (void)signal(SIGCHLD, reapchild);
+       (void)signal(SIGALRM, domark);
+       (void)alarm(TIMERINTVL);
+       (void)unlink(LogName);
+
+#ifndef SUN_LEN
+#define SUN_LEN(unp) (strlen((unp)->sun_path) + 2)
+#endif
+       memset(&sunx, 0, sizeof(sunx));
        sunx.sun_family = AF_UNIX;
        sunx.sun_family = AF_UNIX;
-       (void) strncpy(sunx.sun_path, LogName, sizeof sunx.sun_path);
+       (void)strncpy(sunx.sun_path, LogName, sizeof(sunx.sun_path));
        funix = socket(AF_UNIX, SOCK_DGRAM, 0);
        funix = socket(AF_UNIX, SOCK_DGRAM, 0);
-       if (funix < 0 || bind(funix, (struct sockaddr *) &sunx,
-           sizeof(sunx.sun_family)+sizeof(sunx.sun_len)+
-           strlen(sunx.sun_path)) < 0 ||
+       if (funix < 0 ||
+           bind(funix, (struct sockaddr *)&sunx, SUN_LEN(&sunx)) < 0 ||
            chmod(LogName, 0666) < 0) {
                (void) sprintf(line, "cannot create %s", LogName);
                logerror(line);
            chmod(LogName, 0666) < 0) {
                (void) sprintf(line, "cannot create %s", LogName);
                logerror(line);
@@ -253,6 +245,7 @@ main(argc, argv)
                die(0);
        }
        finet = socket(AF_INET, SOCK_DGRAM, 0);
                die(0);
        }
        finet = socket(AF_INET, SOCK_DGRAM, 0);
+       inetm = 0;
        if (finet >= 0) {
                struct servent *sp;
 
        if (finet >= 0) {
                struct servent *sp;
 
@@ -262,9 +255,10 @@ main(argc, argv)
                        logerror("syslog/udp: unknown service");
                        die(0);
                }
                        logerror("syslog/udp: unknown service");
                        die(0);
                }
+               memset(&sin, 0, sizeof(sin));
                sin.sin_family = AF_INET;
                sin.sin_port = LogPort = sp->s_port;
                sin.sin_family = AF_INET;
                sin.sin_port = LogPort = sp->s_port;
-               if (bind(finet, &sin, sizeof(sin)) < 0) {
+               if (bind(finet, (struct sockaddr *)&sin, sizeof(sin)) < 0) {
                        logerror("bind");
                        if (!Debug)
                                die(0);
                        logerror("bind");
                        if (!Debug)
                                die(0);
@@ -273,10 +267,10 @@ main(argc, argv)
                        InetInuse = 1;
                }
        }
                        InetInuse = 1;
                }
        }
-       if ((fklog = open("/dev/klog", O_RDONLY)) >= 0)
+       if ((fklog = open(_PATH_KLOG, O_RDONLY, 0)) >= 0)
                klogm = FDMASK(fklog);
        else {
                klogm = FDMASK(fklog);
        else {
-               dprintf("can't open /dev/klog (%d)\n", errno);
+               dprintf("can't open %s (%d)\n", _PATH_KLOG, errno);
                klogm = 0;
        }
 
                klogm = 0;
        }
 
@@ -289,16 +283,15 @@ main(argc, argv)
 
        dprintf("off & running....\n");
 
 
        dprintf("off & running....\n");
 
-       init();
-       (void) signal(SIGHUP, init);
+       init(0);
+       (void)signal(SIGHUP, init);
 
        for (;;) {
                int nfds, readfds = FDMASK(funix) | inetm | klogm;
 
 
        for (;;) {
                int nfds, readfds = FDMASK(funix) | inetm | klogm;
 
-               errno = 0;
                dprintf("readfds = %#x\n", readfds);
                dprintf("readfds = %#x\n", readfds);
-               nfds = select(20, (fd_set *) &readfds, (fd_set *) NULL,
-                                 (fd_set *) NULL, (struct timeval *) NULL);
+               nfds = select(20, (fd_set *)&readfds, (fd_set *)NULL,
+                   (fd_set *)NULL, (struct timeval *)NULL);
                if (nfds == 0)
                        continue;
                if (nfds < 0) {
                if (nfds == 0)
                        continue;
                if (nfds < 0) {
@@ -319,9 +312,9 @@ main(argc, argv)
                        }
                }
                if (readfds & FDMASK(funix)) {
                        }
                }
                if (readfds & FDMASK(funix)) {
-                       len = sizeof fromunix;
+                       len = sizeof(fromunix);
                        i = recvfrom(funix, line, MAXLINE, 0,
                        i = recvfrom(funix, line, MAXLINE, 0,
-                                    (struct sockaddr *) &fromunix, &len);
+                           (struct sockaddr *)&fromunix, &len);
                        if (i > 0) {
                                line[i] = '\0';
                                printline(LocalHostName, line);
                        if (i > 0) {
                                line[i] = '\0';
                                printline(LocalHostName, line);
@@ -329,11 +322,10 @@ main(argc, argv)
                                logerror("recvfrom unix");
                }
                if (readfds & inetm) {
                                logerror("recvfrom unix");
                }
                if (readfds & inetm) {
-                       len = sizeof frominet;
-                       i = recvfrom(finet, line, MAXLINE, 0, &frominet, &len);
+                       len = sizeof(frominet);
+                       i = recvfrom(finet, line, MAXLINE, 0,
+                           (struct sockaddr *)&frominet, &len);
                        if (i > 0) {
                        if (i > 0) {
-                               extern char *cvthname();
-
                                line[i] = '\0';
                                printline(cvthname(&frominet), line);
                        } else if (i < 0 && errno != EINTR)
                                line[i] = '\0';
                                printline(cvthname(&frominet), line);
                        } else if (i < 0 && errno != EINTR)
@@ -342,38 +334,26 @@ main(argc, argv)
        }
 }
 
        }
 }
 
+void
 usage()
 {
 usage()
 {
-       fprintf(stderr, "usage: syslogd [-d] [-m markinterval] [-p path] [-f conffile]\n");
-       exit(1);
-}
-
-untty()
-{
-       int i;
 
 
-       if (!Debug) {
-               i = open("/dev/tty", O_RDWR);
-               if (i >= 0) {
-                       (void) ioctl(i, (int) TIOCNOTTY, (char *)0);
-                       (void) close(i);
-               }
-       }
+       (void)fprintf(stderr,
+           "usage: syslogd [-f conffile] [-m markinterval] [-p logpath]\n");
+       exit(1);
 }
 
 /*
  * Take a raw input line, decode the message, and print the message
  * on the appropriate log files.
  */
 }
 
 /*
  * Take a raw input line, decode the message, and print the message
  * on the appropriate log files.
  */
-
+void
 printline(hname, msg)
        char *hname;
        char *msg;
 {
 printline(hname, msg)
        char *hname;
        char *msg;
 {
-       register char *p, *q;
-       register int c;
-       char line[MAXLINE + 1];
-       int pri;
+       int c, pri;
+       char *p, *q, line[MAXLINE + 1];
 
        /* test for special codes */
        pri = DEFUPRI;
 
        /* test for special codes */
        pri = DEFUPRI;
@@ -396,12 +376,16 @@ printline(hname, msg)
 
        while ((c = *p++ & 0177) != '\0' &&
            q < &line[sizeof(line) - 1])
 
        while ((c = *p++ & 0177) != '\0' &&
            q < &line[sizeof(line) - 1])
-               if (c == '\n')
-                       *q++ = ' ';
-               else if (iscntrl(c)) {
-                       *q++ = '^';
-                       *q++ = c ^ 0100;
-               } else
+               if (iscntrl(c))
+                       if (c == '\n')
+                               *q++ = ' ';
+                       else if (c == '\t')
+                               *q++ = '\t';
+                       else {
+                               *q++ = '^';
+                               *q++ = c ^ 0100;
+                       }
+               else
                        *q++ = c;
        *q = '\0';
 
                        *q++ = c;
        *q = '\0';
 
@@ -411,17 +395,14 @@ printline(hname, msg)
 /*
  * Take a raw input line from /dev/klog, split and format similar to syslog().
  */
 /*
  * Take a raw input line from /dev/klog, split and format similar to syslog().
  */
-
+void
 printsys(msg)
        char *msg;
 {
 printsys(msg)
        char *msg;
 {
-       register char *p, *q;
-       register int c;
-       char line[MAXLINE + 1];
-       int pri, flags;
-       char *lp;
+       int c, pri, flags;
+       char *lp, *p, *q, line[MAXLINE + 1];
 
 
-       (void) sprintf(line, "vmunix: ");
+       (void)strcpy(line, "vmunix: ");
        lp = line + strlen(line);
        for (p = msg; *p != '\0'; ) {
                flags = SYNC_FILE | ADDDATE;    /* fsync file after write */
        lp = line + strlen(line);
        for (p = msg; *p != '\0'; ) {
                flags = SYNC_FILE | ADDDATE;    /* fsync file after write */
@@ -453,18 +434,18 @@ time_t    now;
  * Log a message to the appropriate log files, users, etc. based on
  * the priority.
  */
  * Log a message to the appropriate log files, users, etc. based on
  * the priority.
  */
-
+void
 logmsg(pri, msg, from, flags)
        int pri;
        char *msg, *from;
        int flags;
 {
 logmsg(pri, msg, from, flags)
        int pri;
        char *msg, *from;
        int flags;
 {
-       register struct filed *f;
-       int fac, prilev;
-       int omask, msglen;
+       struct filed *f;
+       int fac, msglen, omask, prilev;
        char *timestamp;
 
        char *timestamp;
 
-       dprintf("logmsg: pri %o, flags %x, from %s, msg %s\n", pri, flags, from, msg);
+       dprintf("logmsg: pri %o, flags %x, from %s, msg %s\n",
+           pri, flags, from, msg);
 
        omask = sigblock(sigmask(SIGHUP)|sigmask(SIGALRM));
 
 
        omask = sigblock(sigmask(SIGHUP)|sigmask(SIGALRM));
 
@@ -476,7 +457,7 @@ logmsg(pri, msg, from, flags)
            msg[9] != ':' || msg[12] != ':' || msg[15] != ' ')
                flags |= ADDDATE;
 
            msg[9] != ':' || msg[12] != ':' || msg[15] != ' ')
                flags |= ADDDATE;
 
-       (void) time(&now);
+       (void)time(&now);
        if (flags & ADDDATE)
                timestamp = ctime(&now) + 4;
        else {
        if (flags & ADDDATE)
                timestamp = ctime(&now) + 4;
        else {
@@ -495,19 +476,19 @@ logmsg(pri, msg, from, flags)
        /* log the message to the particular outputs */
        if (!Initialized) {
                f = &consfile;
        /* log the message to the particular outputs */
        if (!Initialized) {
                f = &consfile;
-               f->f_file = open(ctty, O_WRONLY);
+               f->f_file = open(ctty, O_WRONLY, 0);
 
                if (f->f_file >= 0) {
 
                if (f->f_file >= 0) {
-                       untty();
                        fprintlog(f, flags, msg);
                        fprintlog(f, flags, msg);
-                       (void) close(f->f_file);
+                       (void)close(f->f_file);
                }
                }
-               (void) sigsetmask(omask);
+               (void)sigsetmask(omask);
                return;
        }
        for (f = Files; f; f = f->f_next) {
                /* skip messages that are incorrect priority */
                return;
        }
        for (f = Files; f; f = f->f_next) {
                /* skip messages that are incorrect priority */
-               if (f->f_pmask[fac] < prilev || f->f_pmask[fac] == NOPRI)
+               if (f->f_pmask[fac] < prilev ||
+                   f->f_pmask[fac] == INTERNAL_NOPRI)
                        continue;
 
                if (f->f_type == F_CONSOLE && (flags & IGN_CONS))
                        continue;
 
                if (f->f_type == F_CONSOLE && (flags & IGN_CONS))
@@ -523,7 +504,7 @@ logmsg(pri, msg, from, flags)
                if ((flags & MARK) == 0 && msglen == f->f_prevlen &&
                    !strcmp(msg, f->f_prevline) &&
                    !strcmp(from, f->f_prevhost)) {
                if ((flags & MARK) == 0 && msglen == f->f_prevlen &&
                    !strcmp(msg, f->f_prevline) &&
                    !strcmp(from, f->f_prevhost)) {
-                       (void) strncpy(f->f_lasttime, timestamp, 15);
+                       (void)strncpy(f->f_lasttime, timestamp, 15);
                        f->f_prevcount++;
                        dprintf("msg repeated %d times, %ld sec of %d\n",
                            f->f_prevcount, now - f->f_time,
                        f->f_prevcount++;
                        dprintf("msg repeated %d times, %ld sec of %d\n",
                            f->f_prevcount, now - f->f_time,
@@ -543,13 +524,13 @@ logmsg(pri, msg, from, flags)
                        if (f->f_prevcount)
                                fprintlog(f, 0, (char *)NULL);
                        f->f_repeatcount = 0;
                        if (f->f_prevcount)
                                fprintlog(f, 0, (char *)NULL);
                        f->f_repeatcount = 0;
-                       (void) strncpy(f->f_lasttime, timestamp, 15);
-                       (void) strncpy(f->f_prevhost, from,
+                       (void)strncpy(f->f_lasttime, timestamp, 15);
+                       (void)strncpy(f->f_prevhost, from,
                                        sizeof(f->f_prevhost));
                        if (msglen < MAXSVLINE) {
                                f->f_prevlen = msglen;
                                f->f_prevpri = pri;
                                        sizeof(f->f_prevhost));
                        if (msglen < MAXSVLINE) {
                                f->f_prevlen = msglen;
                                f->f_prevpri = pri;
-                               (void) strcpy(f->f_prevline, msg);
+                               (void)strcpy(f->f_prevline, msg);
                                fprintlog(f, flags, (char *)NULL);
                        } else {
                                f->f_prevline[0] = 0;
                                fprintlog(f, flags, (char *)NULL);
                        } else {
                                f->f_prevline[0] = 0;
@@ -558,40 +539,52 @@ logmsg(pri, msg, from, flags)
                        }
                }
        }
                        }
                }
        }
-       (void) sigsetmask(omask);
+       (void)sigsetmask(omask);
 }
 
 }
 
+void
 fprintlog(f, flags, msg)
 fprintlog(f, flags, msg)
-       register struct filed *f;
+       struct filed *f;
        int flags;
        char *msg;
 {
        struct iovec iov[6];
        int flags;
        char *msg;
 {
        struct iovec iov[6];
-       register struct iovec *v = iov;
-       register int l;
-       char line[MAXLINE + 1];
-       char repbuf[80];
-
-       v->iov_base = f->f_lasttime;
-       v->iov_len = 15;
-       v++;
-       v->iov_base = " ";
-       v->iov_len = 1;
-       v++;
+       struct iovec *v;
+       int l;
+       char line[MAXLINE + 1], repbuf[80], greetings[200];
+
+       v = iov;
+       if (f->f_type == F_WALL) {
+               v->iov_base = greetings;
+               v->iov_len = sprintf(greetings,
+                   "\r\n\7Message from syslogd@%s at %.24s ...\r\n",
+                   f->f_prevhost, ctime(&now));
+               v++;
+               v->iov_base = "";
+               v->iov_len = 0;
+               v++;
+       } else {
+               v->iov_base = f->f_lasttime;
+               v->iov_len = 15;
+               v++;
+               v->iov_base = " ";
+               v->iov_len = 1;
+               v++;
+       }
        v->iov_base = f->f_prevhost;
        v->iov_len = strlen(v->iov_base);
        v++;
        v->iov_base = " ";
        v->iov_len = 1;
        v++;
        v->iov_base = f->f_prevhost;
        v->iov_len = strlen(v->iov_base);
        v++;
        v->iov_base = " ";
        v->iov_len = 1;
        v++;
+
        if (msg) {
                v->iov_base = msg;
                v->iov_len = strlen(msg);
        } else if (f->f_prevcount > 1) {
        if (msg) {
                v->iov_base = msg;
                v->iov_len = strlen(msg);
        } else if (f->f_prevcount > 1) {
-               (void) sprintf(repbuf, "last message repeated %d times",
-                   f->f_prevcount);
                v->iov_base = repbuf;
                v->iov_base = repbuf;
-               v->iov_len = strlen(repbuf);
+               v->iov_len = sprintf(repbuf, "last message repeated %d times",
+                   f->f_prevcount);
        } else {
                v->iov_base = f->f_prevline;
                v->iov_len = f->f_prevlen;
        } else {
                v->iov_base = f->f_prevline;
                v->iov_len = f->f_prevlen;
@@ -608,15 +601,15 @@ fprintlog(f, flags, msg)
 
        case F_FORW:
                dprintf(" %s\n", f->f_un.f_forw.f_hname);
 
        case F_FORW:
                dprintf(" %s\n", f->f_un.f_forw.f_hname);
-               (void) sprintf(line, "<%d>%.15s %s", f->f_prevpri,
-                       iov[0].iov_base, iov[4].iov_base);
-               l = strlen(line);
+               l = sprintf(line, "<%d>%.15s %s", f->f_prevpri,
+                   iov[0].iov_base, iov[4].iov_base);
                if (l > MAXLINE)
                        l = MAXLINE;
                if (l > MAXLINE)
                        l = MAXLINE;
-               if (sendto(finet, line, l, 0, &f->f_un.f_forw.f_addr,
-                   sizeof f->f_un.f_forw.f_addr) != l) {
+               if (sendto(finet, line, l, 0,
+                   (struct sockaddr *)&f->f_un.f_forw.f_addr,
+                   sizeof(f->f_un.f_forw.f_addr)) != l) {
                        int e = errno;
                        int e = errno;
-                       (void) close(f->f_file);
+                       (void)close(f->f_file);
                        f->f_type = F_UNUSED;
                        errno = e;
                        logerror("sendto");
                        f->f_type = F_UNUSED;
                        errno = e;
                        logerror("sendto");
@@ -643,26 +636,25 @@ fprintlog(f, flags, msg)
        again:
                if (writev(f->f_file, iov, 6) < 0) {
                        int e = errno;
        again:
                if (writev(f->f_file, iov, 6) < 0) {
                        int e = errno;
-                       (void) close(f->f_file);
+                       (void)close(f->f_file);
                        /*
                        /*
-                        * Check for EBADF on TTY's due to vhangup() XXX
+                        * Check for errors on TTY's due to loss of tty
                         */
                         */
-                       if (e == EBADF && f->f_type != F_FILE) {
-                               f->f_file = open(f->f_un.f_fname, O_WRONLY|O_APPEND);
+                       if ((e == EIO || e == EBADF) && f->f_type != F_FILE) {
+                               f->f_file = open(f->f_un.f_fname,
+                                   O_WRONLY|O_APPEND, 0);
                                if (f->f_file < 0) {
                                        f->f_type = F_UNUSED;
                                        logerror(f->f_un.f_fname);
                                if (f->f_file < 0) {
                                        f->f_type = F_UNUSED;
                                        logerror(f->f_un.f_fname);
-                               } else {
-                                       untty();
+                               } else
                                        goto again;
                                        goto again;
-                               }
                        } else {
                                f->f_type = F_UNUSED;
                                errno = e;
                                logerror(f->f_un.f_fname);
                        }
                } else if (flags & SYNC_FILE)
                        } else {
                                f->f_type = F_UNUSED;
                                errno = e;
                                logerror(f->f_un.f_fname);
                        }
                } else if (flags & SYNC_FILE)
-                       (void) fsync(f->f_file);
+                       (void)fsync(f->f_file);
                break;
 
        case F_USERS:
                break;
 
        case F_USERS:
@@ -676,115 +668,69 @@ fprintlog(f, flags, msg)
        f->f_prevcount = 0;
 }
 
        f->f_prevcount = 0;
 }
 
-jmp_buf ttybuf;
-
-endtty()
-{
-       longjmp(ttybuf, 1);
-}
-
 /*
  *  WALLMSG -- Write a message to the world at large
  *
  *     Write the specified message to either the entire
  *     world, or a list of approved users.
  */
 /*
  *  WALLMSG -- Write a message to the world at large
  *
  *     Write the specified message to either the entire
  *     world, or a list of approved users.
  */
-
+void
 wallmsg(f, iov)
 wallmsg(f, iov)
-       register struct filed *f;
+       struct filed *f;
        struct iovec *iov;
 {
        struct iovec *iov;
 {
-       register char *p;
-       register int i;
-       int ttyf, len;
+       static int reenter;                     /* avoid calling ourselves */
        FILE *uf;
        FILE *uf;
-       static int reenter = 0;
        struct utmp ut;
        struct utmp ut;
-       char greetings[200];
+       int i;
+       char *p;
+       char line[sizeof(ut.ut_line) + 1];
 
        if (reenter++)
                return;
 
        if (reenter++)
                return;
-
-       /* open the user login file */
-       if ((uf = fopen("/etc/utmp", "r")) == NULL) {
-               logerror("/etc/utmp");
+       if ((uf = fopen(_PATH_UTMP, "r")) == NULL) {
+               logerror(_PATH_UTMP);
                reenter = 0;
                return;
        }
                reenter = 0;
                return;
        }
-
-       /*
-        * Might as well fork instead of using nonblocking I/O
-        * and doing notty().
-        */
-       if (fork() == 0) {
-               (void) signal(SIGTERM, SIG_DFL);
-               (void) alarm(0);
-               (void) signal(SIGALRM, endtty);
-               (void) signal(SIGTTOU, SIG_IGN);
-               (void) sigsetmask(0);
-               (void) sprintf(greetings,
-                   "\r\n\7Message from syslogd@%s at %.24s ...\r\n",
-                       iov[2].iov_base, ctime(&now));
-               len = strlen(greetings);
-
-               /* scan the user login file */
-               while (fread((char *) &ut, sizeof ut, 1, uf) == 1) {
-                       /* is this slot used? */
-                       if (ut.ut_name[0] == '\0')
-                               continue;
-
-                       /* should we send the message to this user? */
-                       if (f->f_type == F_USERS) {
-                               for (i = 0; i < MAXUNAMES; i++) {
-                                       if (!f->f_un.f_uname[i][0]) {
-                                               i = MAXUNAMES;
-                                               break;
-                                       }
-                                       if (strncmp(f->f_un.f_uname[i],
-                                           ut.ut_name, UNAMESZ) == 0)
-                                               break;
-                               }
-                               if (i >= MAXUNAMES)
-                                       continue;
-                       }
-
-                       /* compute the device name */
-                       p = "/dev/12345678";
-                       strncpy(&p[5], ut.ut_line, UNAMESZ);
-
-                       if (f->f_type == F_WALL) {
-                               iov[0].iov_base = greetings;
-                               iov[0].iov_len = len;
-                               iov[1].iov_len = 0;
+       /* NOSTRICT */
+       while (fread((char *)&ut, sizeof(ut), 1, uf) == 1) {
+               if (ut.ut_name[0] == '\0')
+                       continue;
+               strncpy(line, ut.ut_line, sizeof(ut.ut_line));
+               line[sizeof(ut.ut_line)] = '\0';
+               if (f->f_type == F_WALL) {
+                       if ((p = ttymsg(iov, 6, line, 60*5)) != NULL) {
+                               errno = 0;      /* already in msg */
+                               logerror(p);
                        }
                        }
-                       if (setjmp(ttybuf) == 0) {
-                               (void) alarm(15);
-                               /* open the terminal */
-                               ttyf = open(p, O_WRONLY);
-                               if (ttyf >= 0) {
-                                       struct stat statb;
-
-                                       if (fstat(ttyf, &statb) == 0 &&
-                                           (statb.st_mode & S_IWRITE))
-                                               (void) writev(ttyf, iov, 6);
-                                       close(ttyf);
-                                       ttyf = -1;
+                       continue;
+               }
+               /* should we send the message to this user? */
+               for (i = 0; i < MAXUNAMES; i++) {
+                       if (!f->f_un.f_uname[i][0])
+                               break;
+                       if (!strncmp(f->f_un.f_uname[i], ut.ut_name,
+                           UT_NAMESIZE)) {
+                               if ((p = ttymsg(iov, 6, line, 60*5)) != NULL) {
+                                       errno = 0;      /* already in msg */
+                                       logerror(p);
                                }
                                }
+                               break;
                        }
                        }
-                       (void) alarm(0);
                }
                }
-               exit(0);
        }
        }
-       /* close the user login file */
-       (void) fclose(uf);
+       (void)fclose(uf);
        reenter = 0;
 }
 
        reenter = 0;
 }
 
-reapchild()
+void
+reapchild(signo)
+       int signo;
 {
        union wait status;
 
 {
        union wait status;
 
-       while (wait3(&status, WNOHANG, (struct rusage *) NULL) > 0)
+       while (wait3((int *)&status, WNOHANG, (struct rusage *)NULL) > 0)
                ;
 }
 
                ;
 }
 
@@ -796,8 +742,7 @@ cvthname(f)
        struct sockaddr_in *f;
 {
        struct hostent *hp;
        struct sockaddr_in *f;
 {
        struct hostent *hp;
-       register char *p;
-       extern char *inet_ntoa();
+       char *p;
 
        dprintf("cvthname(%s)\n", inet_ntoa(f->sin_addr));
 
 
        dprintf("cvthname(%s)\n", inet_ntoa(f->sin_addr));
 
@@ -805,22 +750,25 @@ cvthname(f)
                dprintf("Malformed from address\n");
                return ("???");
        }
                dprintf("Malformed from address\n");
                return ("???");
        }
-       hp = gethostbyaddr(&f->sin_addr, sizeof(struct in_addr), f->sin_family);
+       hp = gethostbyaddr((char *)&f->sin_addr,
+           sizeof(struct in_addr), f->sin_family);
        if (hp == 0) {
                dprintf("Host name for your address (%s) unknown\n",
                        inet_ntoa(f->sin_addr));
                return (inet_ntoa(f->sin_addr));
        }
        if (hp == 0) {
                dprintf("Host name for your address (%s) unknown\n",
                        inet_ntoa(f->sin_addr));
                return (inet_ntoa(f->sin_addr));
        }
-       if ((p = index(hp->h_name, '.')) && strcmp(p + 1, LocalDomain) == 0)
+       if ((p = strchr(hp->h_name, '.')) && strcmp(p + 1, LocalDomain) == 0)
                *p = '\0';
        return (hp->h_name);
 }
 
                *p = '\0';
        return (hp->h_name);
 }
 
-domark()
+void
+domark(signo)
+       int signo;
 {
 {
-       register struct filed *f;
+       struct filed *f;
 
 
-       now = time(0);
+       now = time((time_t *)NULL);
        MarkSeq += TIMERINTVL;
        if (MarkSeq >= MarkInterval) {
                logmsg(LOG_INFO, "-- MARK --", LocalHostName, ADDDATE|MARK);
        MarkSeq += TIMERINTVL;
        if (MarkSeq >= MarkInterval) {
                logmsg(LOG_INFO, "-- MARK --", LocalHostName, ADDDATE|MARK);
@@ -836,31 +784,33 @@ domark()
                        BACKOFF(f);
                }
        }
                        BACKOFF(f);
                }
        }
-       (void) alarm(TIMERINTVL);
+       (void)alarm(TIMERINTVL);
 }
 
 /*
  * Print syslogd errors some place.
  */
 }
 
 /*
  * Print syslogd errors some place.
  */
+void
 logerror(type)
        char *type;
 {
        char buf[100];
 
 logerror(type)
        char *type;
 {
        char buf[100];
 
-       if (errno == 0)
-               (void) sprintf(buf, "syslogd: %s", type);
-       else if ((unsigned) errno > sys_nerr)
-               (void) sprintf(buf, "syslogd: %s: error %d", type, errno);
+       if (errno)
+               (void)snprintf(buf,
+                   sizeof(buf), "syslogd: %s: %s", type, strerror(errno));
        else
        else
-               (void) sprintf(buf, "syslogd: %s: %s", type, sys_errlist[errno]);
+               (void)snprintf(buf, sizeof(buf), "syslogd: %s", type);
        errno = 0;
        dprintf("%s\n", buf);
        logmsg(LOG_SYSLOG|LOG_ERR, buf, LocalHostName, ADDDATE);
 }
 
        errno = 0;
        dprintf("%s\n", buf);
        logmsg(LOG_SYSLOG|LOG_ERR, buf, LocalHostName, ADDDATE);
 }
 
-die(sig)
+void
+die(signo)
+       int signo;
 {
 {
-       register struct filed *f;
+       struct filed *f;
        char buf[100];
 
        for (f = Files; f != NULL; f = f->f_next) {
        char buf[100];
 
        for (f = Files; f != NULL; f = f->f_next) {
@@ -868,27 +818,28 @@ die(sig)
                if (f->f_prevcount)
                        fprintlog(f, 0, (char *)NULL);
        }
                if (f->f_prevcount)
                        fprintlog(f, 0, (char *)NULL);
        }
-       if (sig) {
-               dprintf("syslogd: exiting on signal %d\n", sig);
-               (void) sprintf(buf, "exiting on signal %d", sig);
+       if (signo) {
+               dprintf("syslogd: exiting on signal %d\n", signo);
+               (void)sprintf(buf, "exiting on signal %d", signo);
                errno = 0;
                logerror(buf);
        }
                errno = 0;
                logerror(buf);
        }
-       (void) unlink(LogName);
+       (void)unlink(LogName);
        exit(0);
 }
 
 /*
  *  INIT -- Initialize syslogd from configuration table
  */
        exit(0);
 }
 
 /*
  *  INIT -- Initialize syslogd from configuration table
  */
-
-init()
+void
+init(signo)
+       int signo;
 {
 {
-       register int i;
-       register FILE *cf;
-       register struct filed *f, *next, **nextp;
-       register char *p;
-       char cline[BUFSIZ];
+       int i;
+       FILE *cf;
+       struct filed *f, *next, **nextp;
+       char *p;
+       char cline[LINE_MAX];
 
        dprintf("init\n");
 
 
        dprintf("init\n");
 
@@ -902,14 +853,15 @@ init()
                        fprintlog(f, 0, (char *)NULL);
 
                switch (f->f_type) {
                        fprintlog(f, 0, (char *)NULL);
 
                switch (f->f_type) {
-                 case F_FILE:
-                 case F_TTY:
-                 case F_CONSOLE:
-                       (void) close(f->f_file);
+               case F_FILE:
+               case F_TTY:
+               case F_CONSOLE:
+               case F_FORW:
+                       (void)close(f->f_file);
                        break;
                }
                next = f->f_next;
                        break;
                }
                next = f->f_next;
-               free((char *) f);
+               free((char *)f);
        }
        Files = NULL;
        nextp = &Files;
        }
        Files = NULL;
        nextp = &Files;
@@ -929,15 +881,17 @@ init()
         *  Foreach line in the conf table, open that file.
         */
        f = NULL;
         *  Foreach line in the conf table, open that file.
         */
        f = NULL;
-       while (fgets(cline, sizeof cline, cf) != NULL) {
+       while (fgets(cline, sizeof(cline), cf) != NULL) {
                /*
                 * check for end-of-section, comments, strip off trailing
                 * spaces and newline character.
                 */
                /*
                 * check for end-of-section, comments, strip off trailing
                 * spaces and newline character.
                 */
-               for (p = cline; isspace(*p); ++p);
+               for (p = cline; isspace(*p); ++p)
+                       continue;
                if (*p == NULL || *p == '#')
                        continue;
                if (*p == NULL || *p == '#')
                        continue;
-               for (p = index(cline, '\0'); isspace(*--p););
+               for (p = strchr(cline, '\0'); isspace(*--p);)
+                       continue;
                *++p = '\0';
                f = (struct filed *)calloc(1, sizeof(*f));
                *nextp = f;
                *++p = '\0';
                f = (struct filed *)calloc(1, sizeof(*f));
                *nextp = f;
@@ -946,14 +900,14 @@ init()
        }
 
        /* close the configuration file */
        }
 
        /* close the configuration file */
-       (void) fclose(cf);
+       (void)fclose(cf);
 
        Initialized = 1;
 
        if (Debug) {
                for (f = Files; f; f = f->f_next) {
                        for (i = 0; i <= LOG_NFACILITIES; i++)
 
        Initialized = 1;
 
        if (Debug) {
                for (f = Files; f; f = f->f_next) {
                        for (i = 0; i <= LOG_NFACILITIES; i++)
-                               if (f->f_pmask[i] == NOPRI)
+                               if (f->f_pmask[i] == INTERNAL_NOPRI)
                                        printf("X ");
                                else
                                        printf("%d ", f->f_pmask[i]);
                                        printf("X ");
                                else
                                        printf("%d ", f->f_pmask[i]);
@@ -985,71 +939,24 @@ init()
 /*
  * Crack a configuration file line
  */
 /*
  * Crack a configuration file line
  */
-
-struct code {
-       char    *c_name;
-       int     c_val;
-};
-
-struct code    PriNames[] = {
-       "panic",        LOG_EMERG,
-       "emerg",        LOG_EMERG,
-       "alert",        LOG_ALERT,
-       "crit",         LOG_CRIT,
-       "err",          LOG_ERR,
-       "error",        LOG_ERR,
-       "warn",         LOG_WARNING,
-       "warning",      LOG_WARNING,
-       "notice",       LOG_NOTICE,
-       "info",         LOG_INFO,
-       "debug",        LOG_DEBUG,
-       "none",         NOPRI,
-       NULL,           -1
-};
-
-struct code    FacNames[] = {
-       "kern",         LOG_KERN,
-       "user",         LOG_USER,
-       "mail",         LOG_MAIL,
-       "daemon",       LOG_DAEMON,
-       "auth",         LOG_AUTH,
-       "security",     LOG_AUTH,
-       "mark",         LOG_MARK,
-       "syslog",       LOG_SYSLOG,
-       "lpr",          LOG_LPR,
-       "news",         LOG_NEWS,
-       "uucp",         LOG_UUCP,
-       "local0",       LOG_LOCAL0,
-       "local1",       LOG_LOCAL1,
-       "local2",       LOG_LOCAL2,
-       "local3",       LOG_LOCAL3,
-       "local4",       LOG_LOCAL4,
-       "local5",       LOG_LOCAL5,
-       "local6",       LOG_LOCAL6,
-       "local7",       LOG_LOCAL7,
-       NULL,           -1
-};
-
+void
 cfline(line, f)
        char *line;
 cfline(line, f)
        char *line;
-       register struct filed *f;
+       struct filed *f;
 {
 {
-       register char *p;
-       register char *q;
-       register int i;
-       char *bp;
-       int pri;
        struct hostent *hp;
        struct hostent *hp;
-       char buf[MAXLINE];
+       int i, pri;
+       char *bp, *p, *q;
+       char buf[MAXLINE], ebuf[100];
 
        dprintf("cfline(%s)\n", line);
 
 
        dprintf("cfline(%s)\n", line);
 
-       errno = 0;      /* keep sys_errlist stuff out of logerror messages */
+       errno = 0;      /* keep strerror() stuff out of logerror messages */
 
        /* clear out file entry */
 
        /* clear out file entry */
-       bzero((char *) f, sizeof *f);
+       memset(f, 0, sizeof(*f));
        for (i = 0; i <= LOG_NFACILITIES; i++)
        for (i = 0; i <= LOG_NFACILITIES; i++)
-               f->f_pmask[i] = NOPRI;
+               f->f_pmask[i] = INTERNAL_NOPRI;
 
        /* scan through the list of selectors */
        for (p = line; *p && *p != '\t';) {
 
        /* scan through the list of selectors */
        for (p = line; *p && *p != '\t';) {
@@ -1059,39 +966,42 @@ cfline(line, f)
                        continue;
 
                /* collect priority name */
                        continue;
 
                /* collect priority name */
-               for (bp = buf; *q && !index("\t,;", *q); )
+               for (bp = buf; *q && !strchr("\t,;", *q); )
                        *bp++ = *q++;
                *bp = '\0';
 
                /* skip cruft */
                        *bp++ = *q++;
                *bp = '\0';
 
                /* skip cruft */
-               while (index(", ;", *q))
+               while (strchr(", ;", *q))
                        q++;
 
                /* decode priority name */
                        q++;
 
                /* decode priority name */
-               pri = decode(buf, PriNames);
-               if (pri < 0) {
-                       char xbuf[200];
-
-                       (void) sprintf(xbuf, "unknown priority name \"%s\"", buf);
-                       logerror(xbuf);
-                       return;
+               if (*buf == '*')
+                       pri = LOG_PRIMASK + 1;
+               else {
+                       pri = decode(buf, prioritynames);
+                       if (pri < 0) {
+                               (void)sprintf(ebuf,
+                                   "unknown priority name \"%s\"", buf);
+                               logerror(ebuf);
+                               return;
+                       }
                }
 
                /* scan facilities */
                }
 
                /* scan facilities */
-               while (*p && !index("\t.;", *p)) {
-                       for (bp = buf; *p && !index("\t,;.", *p); )
+               while (*p && !strchr("\t.;", *p)) {
+                       for (bp = buf; *p && !strchr("\t,;.", *p); )
                                *bp++ = *p++;
                        *bp = '\0';
                        if (*buf == '*')
                                for (i = 0; i < LOG_NFACILITIES; i++)
                                        f->f_pmask[i] = pri;
                        else {
                                *bp++ = *p++;
                        *bp = '\0';
                        if (*buf == '*')
                                for (i = 0; i < LOG_NFACILITIES; i++)
                                        f->f_pmask[i] = pri;
                        else {
-                               i = decode(buf, FacNames);
+                               i = decode(buf, facilitynames);
                                if (i < 0) {
                                if (i < 0) {
-                                       char xbuf[200];
-
-                                       (void) sprintf(xbuf, "unknown facility name \"%s\"", buf);
-                                       logerror(xbuf);
+                                       (void)sprintf(ebuf,
+                                           "unknown facility name \"%s\"",
+                                           buf);
+                                       logerror(ebuf);
                                        return;
                                }
                                f->f_pmask[i >> 3] = pri;
                                        return;
                                }
                                f->f_pmask[i >> 3] = pri;
@@ -1112,35 +1022,31 @@ cfline(line, f)
        case '@':
                if (!InetInuse)
                        break;
        case '@':
                if (!InetInuse)
                        break;
-               (void) strcpy(f->f_un.f_forw.f_hname, ++p);
+               (void)strcpy(f->f_un.f_forw.f_hname, ++p);
                hp = gethostbyname(p);
                if (hp == NULL) {
                hp = gethostbyname(p);
                if (hp == NULL) {
-                       extern int h_errno, h_nerr;
-                       extern char **h_errlist;
+                       extern int h_errno;
 
 
-                       logerror((u_int)h_errno < h_nerr ?
-                           h_errlist[h_errno] : "Unknown error");
+                       logerror(hstrerror(h_errno));
                        break;
                }
                        break;
                }
-               bzero((char *) &f->f_un.f_forw.f_addr,
-                        sizeof f->f_un.f_forw.f_addr);
+               memset(&f->f_un.f_forw.f_addr, 0,
+                        sizeof(f->f_un.f_forw.f_addr));
                f->f_un.f_forw.f_addr.sin_family = AF_INET;
                f->f_un.f_forw.f_addr.sin_port = LogPort;
                f->f_un.f_forw.f_addr.sin_family = AF_INET;
                f->f_un.f_forw.f_addr.sin_port = LogPort;
-               bcopy(hp->h_addr, (char *) &f->f_un.f_forw.f_addr.sin_addr, hp->h_length);
+               memmove(&f->f_un.f_forw.f_addr.sin_addr, hp->h_addr, hp->h_length);
                f->f_type = F_FORW;
                break;
 
        case '/':
                f->f_type = F_FORW;
                break;
 
        case '/':
-               (void) strcpy(f->f_un.f_fname, p);
-               if ((f->f_file = open(p, O_WRONLY|O_APPEND)) < 0) {
+               (void)strcpy(f->f_un.f_fname, p);
+               if ((f->f_file = open(p, O_WRONLY|O_APPEND, 0)) < 0) {
                        f->f_file = F_UNUSED;
                        logerror(p);
                        break;
                }
                        f->f_file = F_UNUSED;
                        logerror(p);
                        break;
                }
-               if (isatty(f->f_file)) {
+               if (isatty(f->f_file))
                        f->f_type = F_TTY;
                        f->f_type = F_TTY;
-                       untty();
-               }
                else
                        f->f_type = F_FILE;
                if (strcmp(p, ctty) == 0)
                else
                        f->f_type = F_FILE;
                if (strcmp(p, ctty) == 0)
@@ -1155,9 +1061,9 @@ cfline(line, f)
                for (i = 0; i < MAXUNAMES && *p; i++) {
                        for (q = p; *q && *q != ','; )
                                q++;
                for (i = 0; i < MAXUNAMES && *p; i++) {
                        for (q = p; *q && *q != ','; )
                                q++;
-                       (void) strncpy(f->f_un.f_uname[i], p, UNAMESZ);
-                       if ((q - p) > UNAMESZ)
-                               f->f_un.f_uname[i][UNAMESZ] = '\0';
+                       (void)strncpy(f->f_un.f_uname[i], p, UT_NAMESIZE);
+                       if ((q - p) > UT_NAMESIZE)
+                               f->f_un.f_uname[i][UT_NAMESIZE] = '\0';
                        else
                                f->f_un.f_uname[i][q - p] = '\0';
                        while (*q == ',' || *q == ' ')
                        else
                                f->f_un.f_uname[i][q - p] = '\0';
                        while (*q == ',' || *q == ' ')
@@ -1173,22 +1079,24 @@ cfline(line, f)
 /*
  *  Decode a symbolic name to a numeric value
  */
 /*
  *  Decode a symbolic name to a numeric value
  */
-
+int
 decode(name, codetab)
 decode(name, codetab)
-       char *name;
-       struct code *codetab;
+       const char *name;
+       CODE *codetab;
 {
 {
-       register struct code *c;
-       register char *p;
-       char buf[40];
+       CODE *c;
+       char *p, buf[40];
 
        if (isdigit(*name))
                return (atoi(name));
 
 
        if (isdigit(*name))
                return (atoi(name));
 
-       (void) strcpy(buf, name);
-       for (p = buf; *p; p++)
-               if (isupper(*p))
-                       *p = tolower(*p);
+       for (p = buf; *name && p < &buf[sizeof(buf) - 1]; p++, name++) {
+               if (isupper(*name))
+                       *p = tolower(*name);
+               else
+                       *p = *name;
+       }
+       *p = '\0';
        for (c = codetab; c->c_name; c++)
                if (!strcmp(buf, c->c_name))
                        return (c->c_val);
        for (c = codetab; c->c_name; c++)
                if (!strcmp(buf, c->c_name))
                        return (c->c_val);
Continuous source code history from original PDP-7 UNIX to FreeBSD 2, the first fully unencumbered FreeBSD release.