don't pass through NOTIFY= unless it was given in the SMTP RCPT

[unix-history] / usr / src / usr.sbin / sendmail / src / recipient.c

diff --git a/usr/src/usr.sbin/sendmail/src/recipient.c b/usr/src/usr.sbin/sendmail/src/recipient.c
index b3204c4..dc74e8a 100644 (file)
--- a/usr/src/usr.sbin/sendmail/src/recipient.c
+++ b/usr/src/usr.sbin/sendmail/src/recipient.c
@@ -7,7 +7,7 @@
  */
 
 #ifndef lint
  */
 
 #ifndef lint

-static char sccsid[] = "@(#)recipient.c        8.61 (Berkeley) %G%";
+static char sccsid[] = "@(#)recipient.c        8.74 (Berkeley) %G%";

 #endif /* not lint */
 
 # include "sendmail.h"
 #endif /* not lint */
 
 # include "sendmail.h"


@@ -48,7 +48,7 @@ static char sccsid[] = "@(#)recipient.c       8.61 (Berkeley) %G%";
 #define MAXRCRSN       10      /* maximum levels of alias recursion */
 
 /* q_flags bits inherited from ctladdr */
 #define MAXRCRSN       10      /* maximum levels of alias recursion */
 
 /* q_flags bits inherited from ctladdr */

-#define QINHERITEDBITS (QPINGONSUCCESS|QPINGONFAILURE|QPINGONDELAY|QHAS_RET_PARAM|QRET_HDRS)
+#define QINHERITEDBITS (QPINGONSUCCESS|QPINGONFAILURE|QPINGONDELAY|QHASNOTIFY)

 
 int
 ADDRESS *
 
 int
 ADDRESS *


@@ -65,9 +65,9 @@ sendto(list, copyf, ctladdr, qflags)
        bool firstone;          /* set on first address sent */
        char delimiter;         /* the address delimiter */
        int naddrs;
        bool firstone;          /* set on first address sent */
        char delimiter;         /* the address delimiter */
        int naddrs;

+       int i;

        char *oldto = e->e_to;
        char *oldto = e->e_to;

-       static char *bufp = NULL;
-       static int buflen;
+       char *bufp;

        char buf[MAXNAME + 1];
        ADDRESS *sibl;          /* sibling pointer in tree */
        ADDRESS *prev;          /* previous sibling */
        char buf[MAXNAME + 1];
        ADDRESS *sibl;          /* sibling pointer in tree */
        ADDRESS *prev;          /* previous sibling */


@@ -97,20 +97,13 @@ sendto(list, copyf, ctladdr, qflags)
        al = NULL;
        naddrs = 0;
 
        al = NULL;
        naddrs = 0;
 

-       if (buf == NULL)
-       {
+       /* make sure we have enough space to copy the string */
+       i = strlen(list) + 1;
+       if (i <= sizeof buf)

                bufp = buf;
                bufp = buf;

-               buflen = sizeof buf - 1;
-       }
-       if (strlen(list) > buflen)
-       {
-               /* allocate additional space */
-               if (bufp != buf)
-                       free(bufp);
-               buflen = strlen(list);
-               bufp = malloc(buflen + 1);
-       }
-       strcpy(bufp, list);
+       else
+               bufp = xalloc(i);
+       strcpy(bufp, denlstring(list, FALSE, TRUE));

 
        for (p = bufp; *p != '\0'; )
        {
 
        for (p = bufp; *p != '\0'; )
        {


@@ -154,6 +147,8 @@ sendto(list, copyf, ctladdr, qflags)
        }
 
        e->e_to = oldto;
        }
 
        e->e_to = oldto;

+       if (bufp != buf)
+               free(bufp);

        return (naddrs);
        if (ctladdr != NULL)
                ctladdr->q_child = prev;
        return (naddrs);
        if (ctladdr != NULL)
                ctladdr->q_child = prev;


@@ -229,7 +224,7 @@ recipient(a, sendq, aliaslevel, e)
        int findusercount = 0;
        int i;
        char *buf;
        int findusercount = 0;
        int i;
        char *buf;

-       char buf0[MAXNAME];             /* unquoted image of the user name */
+       char buf0[MAXNAME + 1];         /* unquoted image of the user name */

        extern int safefile();
 
        e->e_to = a->q_paddr;
        extern int safefile();
 
        e->e_to = a->q_paddr;


@@ -264,7 +259,7 @@ recipient(a, sendq, aliaslevel, e)
 
        /* get unquoted user for file, program or user.name check */
        i = strlen(a->q_user);
 
        /* get unquoted user for file, program or user.name check */
        i = strlen(a->q_user);

-       if (i >= sizeof buf)
+       if (i >= sizeof buf0)

                buf = xalloc(i + 1);
        else
                buf = buf0;
                buf = xalloc(i + 1);
        else
                buf = buf0;


@@ -411,7 +406,7 @@ recipient(a, sendq, aliaslevel, e)
                        usrerr("550 Address %s is unsafe for mailing to files",
                                a->q_alias->q_paddr);
                }
                        usrerr("550 Address %s is unsafe for mailing to files",
                                a->q_alias->q_paddr);
                }

-               else if (!writable(buf, getctladdr(a), SFF_ANYFILE))
+               else if (!writable(buf, getctladdr(a), SFF_CREAT))

                {
                        a->q_flags |= QBADADDR;
                        giveresponse(EX_CANTCREAT, m, NULL, a->q_alias,
                {
                        a->q_flags |= QBADADDR;
                        giveresponse(EX_CANTCREAT, m, NULL, a->q_alias,


@@ -491,7 +486,7 @@ recipient(a, sendq, aliaslevel, e)
                }
                else
                {
                }
                else
                {

-                       char nbuf[MAXNAME];
+                       char nbuf[MAXNAME + 1];

 
                        if (fuzzy)
                        {
 
                        if (fuzzy)
                        {


@@ -690,33 +685,10 @@ writable(filename, ctladdr, flags)
        int bits;
        register char *p;
        char *uname;
        int bits;
        register char *p;
        char *uname;

-       struct stat stb;
-       extern char RealUserName[];

 
        if (tTd(29, 5))
                printf("writable(%s, %x)\n", filename, flags);
 
 
        if (tTd(29, 5))
                printf("writable(%s, %x)\n", filename, flags);
 

-#ifdef HASLSTAT
-       if ((bitset(SFF_NOSLINK, flags) ? lstat(filename, &stb)
-                                       : stat(filename, &stb)) < 0)
-#else
-       if (stat(filename, &stb) < 0)
-#endif
-       {
-               /* file does not exist -- see if directory is safe */
-               p = strrchr(filename, '/');
-               if (p == NULL)
-               {
-                       errno = ENOTDIR;
-                       return FALSE;
-               }
-               *p = '\0';
-               errno = safefile(filename, RealUid, RealGid, RealUserName,
-                                SFF_MUSTOWN, S_IWRITE|S_IEXEC);
-               *p = '/';
-               return errno == 0;
-       }
-

 #ifdef SUID_ROOT_FILES_OK
        /* really ought to be passed down -- and not a good idea */
        flags |= SFF_ROOTOK;
 #ifdef SUID_ROOT_FILES_OK
        /* really ought to be passed down -- and not a good idea */
        flags |= SFF_ROOTOK;


@@ -726,14 +698,6 @@ writable(filename, ctladdr, flags)
        **  File does exist -- check that it is writable.
        */
 
        **  File does exist -- check that it is writable.
        */
 

-       if (bitset(0111, stb.st_mode))
-       {
-               if (tTd(29, 5))
-                       printf("failed (mode %o: x bits)\n", stb.st_mode);
-               errno = EPERM;
-               return (FALSE);
-       }
-

        if (ctladdr != NULL && geteuid() == 0)
        {
                euid = ctladdr->q_uid;
        if (ctladdr != NULL && geteuid() == 0)
        {
                euid = ctladdr->q_uid;


@@ -743,6 +707,8 @@ writable(filename, ctladdr, flags)
 #ifdef RUN_AS_REAL_UID
        else
        {
 #ifdef RUN_AS_REAL_UID
        else
        {

+               extern char RealUserName[];
+

                euid = RealUid;
                egid = RealGid;
                uname = RealUserName;
                euid = RealUid;
                egid = RealGid;
                uname = RealUserName;


@@ -766,23 +732,9 @@ writable(filename, ctladdr, flags)
        if (egid == 0)
                egid = DefGid;
        if (geteuid() == 0)
        if (egid == 0)
                egid = DefGid;
        if (geteuid() == 0)

-       {
-               if (bitset(S_ISUID, stb.st_mode) &&
-                   (stb.st_uid != 0 || bitset(SFF_ROOTOK, flags)))
-               {
-                       euid = stb.st_uid;
-                       uname = NULL;
-               }
-               if (bitset(S_ISGID, stb.st_mode) &&
-                   (stb.st_gid != 0 || bitset(SFF_ROOTOK, flags)))
-                       egid = stb.st_gid;
-       }
-
-       if (tTd(29, 5))
-               printf("\teu/gid=%d/%d, st_u/gid=%d/%d\n",
-                       euid, egid, stb.st_uid, stb.st_gid);
+               flags |= SFF_SETUIDOK;

 
 

-       errno = safefile(filename, euid, egid, uname, flags, S_IWRITE);
+       errno = safefile(filename, euid, egid, uname, flags, S_IWRITE, NULL);

        return errno == 0;
 }
 \f/*
        return errno == 0;
 }
 \f/*


@@ -822,11 +774,7 @@ writable(filename, ctladdr, flags)
 */
 
 static jmp_buf CtxIncludeTimeout;
 */
 
 static jmp_buf CtxIncludeTimeout;

-static int     includetimeout();
-
-#ifndef S_IWOTH
-# define S_IWOTH       (S_IWRITE >> 6)
-#endif
+static void    includetimeout();

 
 int
 include(fname, forwarding, ctladdr, sendq, aliaslevel, e)
 
 int
 include(fname, forwarding, ctladdr, sendq, aliaslevel, e)


@@ -837,7 +785,7 @@ include(fname, forwarding, ctladdr, sendq, aliaslevel, e)
        int aliaslevel;
        ENVELOPE *e;
 {
        int aliaslevel;
        ENVELOPE *e;
 {

-       register FILE *fp = NULL;
+       FILE *fp = NULL;

        char *oldto = e->e_to;
        char *oldfilename = FileName;
        int oldlinenumber = LineNumber;
        char *oldto = e->e_to;
        char *oldfilename = FileName;
        int oldlinenumber = LineNumber;


@@ -848,7 +796,7 @@ include(fname, forwarding, ctladdr, sendq, aliaslevel, e)
        gid_t savedgid, gid;
        char *uname;
        int rval = 0;
        gid_t savedgid, gid;
        char *uname;
        int rval = 0;

-       int sfflags = forwarding ? SFF_MUSTOWN : SFF_ANYFILE;
+       int sfflags = SFF_REGONLY;

        struct stat st;
        char buf[MAXLINE];
 #ifdef _POSIX_CHOWN_RESTRICTED
        struct stat st;
        char buf[MAXLINE];
 #ifdef _POSIX_CHOWN_RESTRICTED


@@ -883,34 +831,38 @@ include(fname, forwarding, ctladdr, sendq, aliaslevel, e)
        if (tTd(27, 9))
                printf("include: old uid = %d/%d\n", getuid(), geteuid());
 
        if (tTd(27, 9))
                printf("include: old uid = %d/%d\n", getuid(), geteuid());
 

+       if (forwarding)
+               sfflags |= SFF_MUSTOWN;
+

        ca = getctladdr(ctladdr);
        if (ca == NULL)
        {
                uid = DefUid;
                gid = DefGid;
                uname = DefUser;
        ca = getctladdr(ctladdr);
        if (ca == NULL)
        {
                uid = DefUid;
                gid = DefGid;
                uname = DefUser;

-               saveduid = -1;

        }
        else
        {
                uid = ca->q_uid;
                gid = ca->q_gid;
                uname = ca->q_user;
        }
        else
        {
                uid = ca->q_uid;
                gid = ca->q_gid;
                uname = ca->q_user;

+       }

 #ifdef HASSETREUID
 #ifdef HASSETREUID

-               saveduid = geteuid();
-               savedgid = getegid();
-               if (saveduid == 0)
+       saveduid = geteuid();
+       savedgid = getegid();
+       if (saveduid == 0)
+       {
+               initgroups(uname, gid);
+               if (uid != 0)

                {
                {

-                       initgroups(uname, gid);
-                       if (uid != 0)
-                       {
-                               if (setreuid(0, uid) < 0)
-                                       syserr("setreuid(0, %d) failure (real=%d, eff=%d)",
-                                               uid, getuid(), geteuid());
-                       }
+                       if (setreuid(0, uid) < 0)
+                               syserr("setreuid(0, %d) failure (real=%d, eff=%d)",
+                                       uid, getuid(), geteuid());
+                       else
+                               sfflags |= SFF_NOPATHCHECK;

                }
                }

-#endif                   

        }
        }

+#endif                   

 
        if (tTd(27, 9))
                printf("include: new uid = %d/%d\n", getuid(), geteuid());
 
        if (tTd(27, 9))
                printf("include: new uid = %d/%d\n", getuid(), geteuid());


@@ -935,7 +887,7 @@ include(fname, forwarding, ctladdr, sendq, aliaslevel, e)
                ev = NULL;
 
        /* the input file must be marked safe */
                ev = NULL;
 
        /* the input file must be marked safe */

-       rval = safefile(fname, uid, gid, uname, sfflags, S_IREAD);
+       rval = safefile(fname, uid, gid, uname, sfflags, S_IREAD, NULL);

        if (rval != 0)
        {
                /* don't use this :include: file */
        if (rval != 0)
        {
                /* don't use this :include: file */


@@ -1099,7 +1051,7 @@ resetuid:
        return rval;
 }
 
        return rval;
 }
 

-static
+static void

 includetimeout()
 {
        longjmp(CtxIncludeTimeout, 1);
 includetimeout()
 {
        longjmp(CtxIncludeTimeout, 1);