put redundant stuff in subroutines; add WILLRELE support
[unix-history] / usr / src / sys / kern / kern_synch.c
index 659b766..efc9f73 100644 (file)
@@ -1,32 +1,41 @@
-/*
- * Copyright (c) 1982, 1986, 1990 Regents of the University of California.
- * All rights reserved.  The Berkeley software License Agreement
- * specifies the terms and conditions for redistribution.
+/*-
+ * Copyright (c) 1982, 1986, 1990 The Regents of the University of California.
+ * Copyright (c) 1991 The Regents of the University of California.
+ * All rights reserved.
+ *
+ * %sccs.include.redist.c%
  *
  *
- *     @(#)kern_synch.c        7.12 (Berkeley) %G%
+ *     @(#)kern_synch.c        7.24 (Berkeley) %G%
  */
 
  */
 
-#include "machine/pte.h"
-#include "machine/psl.h"
-#include "machine/mtpr.h"
-
 #include "param.h"
 #include "systm.h"
 #include "param.h"
 #include "systm.h"
-#include "user.h"
 #include "proc.h"
 #include "proc.h"
-#include "vm.h"
 #include "kernel.h"
 #include "buf.h"
 #include "kernel.h"
 #include "buf.h"
+#include "signalvar.h"
+#include "resourcevar.h"
+#include "vmmeter.h"
+#ifdef KTRACE
+#include "ktrace.h"
+#endif
+
+#include "machine/cpu.h"
+
+u_char curpri;                 /* usrpri of curproc */
+int    lbolt;                  /* once a second sleep address */
 
 /*
  * Force switch among equal priority processes every 100ms.
  */
 
 /*
  * Force switch among equal priority processes every 100ms.
  */
-roundrobin()
+/* ARGSUSED */
+void
+roundrobin(arg)
+       void *arg;
 {
 
 {
 
-       runrun++;
-       aston();
-       timeout(roundrobin, (caddr_t)0, hz / 10);
+       need_resched();
+       timeout(roundrobin, (void *)0, hz / 10);
 }
 
 /*
 }
 
 /*
@@ -79,7 +88,7 @@ roundrobin()
  *    Solve (factor)**(power) =~ .1 given power (5*loadav):
  *     solving for factor,
  *      ln(factor) =~ (-2.30/5*loadav), or
  *    Solve (factor)**(power) =~ .1 given power (5*loadav):
  *     solving for factor,
  *      ln(factor) =~ (-2.30/5*loadav), or
- *      factor =~ exp(-1/((5/2.30)*loadav) =~ exp(-1/(2*loadav)) =
+ *      factor =~ exp(-1/((5/2.30)*loadav)) =~ exp(-1/(2*loadav)) =
  *          exp(-1/b) =~ (b-1)/b =~ b/(b+1).                    QED
  *
  * Proof of (2):
  *          exp(-1/b) =~ (b-1)/b =~ b/(b+1).                    QED
  *
  * Proof of (2):
@@ -94,8 +103,8 @@ roundrobin()
  */
 
 /* calculations for digital decay to forget 90% of usage in 5*loadav sec */
  */
 
 /* calculations for digital decay to forget 90% of usage in 5*loadav sec */
-#define        get_b(loadav)           (2 * (loadav))
-#define        get_pcpu(b, cpu)        (((b) * ((cpu) & 0377)) / ((b) + FSCALE))
+#define        loadfactor(loadav)      (2 * (loadav))
+#define        decay_cpu(loadfac, cpu) (((loadfac) * (cpu)) / ((loadfac) + FSCALE))
 
 /* decay 95% of `p_pctcpu' in 60 seconds; see CCPU_SHIFT before changing */
 fixpt_t        ccpu = 0.95122942450071400909 * FSCALE;         /* exp(-1/20) */
 
 /* decay 95% of `p_pctcpu' in 60 seconds; see CCPU_SHIFT before changing */
 fixpt_t        ccpu = 0.95122942450071400909 * FSCALE;         /* exp(-1/20) */
@@ -117,19 +126,26 @@ fixpt_t   ccpu = 0.95122942450071400909 * FSCALE;         /* exp(-1/20) */
 /*
  * Recompute process priorities, once a second
  */
 /*
  * Recompute process priorities, once a second
  */
-schedcpu()
+/* ARGSUSED */
+void
+schedcpu(arg)
+       void *arg;
 {
 {
-       register fixpt_t b = get_b(averunnable[0]);
+       register fixpt_t loadfac = loadfactor(averunnable.ldavg[0]);
        register struct proc *p;
        register struct proc *p;
-       register int s, a;
+       register int s;
+       register unsigned int newcpu;
 
        wakeup((caddr_t)&lbolt);
 
        wakeup((caddr_t)&lbolt);
-       for (p = allproc; p != NULL; p = p->p_nxt) {
-               if (p->p_time != 127)
-                       p->p_time++;
-               if (p->p_stat==SSLEEP || p->p_stat==SSTOP)
-                       if (p->p_slptime != 127)
-                               p->p_slptime++;
+       for (p = (struct proc *)allproc; p != NULL; p = p->p_nxt) {
+               /*
+                * Increment time in/out of memory and sleep time
+                * (if sleeping).  We ignore overflow; with 16-bit int's
+                * (remember them?) overflow takes 45 days.
+                */
+               p->p_time++;
+               if (p->p_stat == SSLEEP || p->p_stat == SSTOP)
+                       p->p_slptime++;
                p->p_pctcpu = (p->p_pctcpu * ccpu) >> FSHIFT;
                /*
                 * If the process has slept the entire second,
                p->p_pctcpu = (p->p_pctcpu * ccpu) >> FSHIFT;
                /*
                 * If the process has slept the entire second,
@@ -150,17 +166,13 @@ schedcpu()
                        (p->p_cpticks * FSCALE / hz)) >> FSHIFT;
 #endif
                p->p_cpticks = 0;
                        (p->p_cpticks * FSCALE / hz)) >> FSHIFT;
 #endif
                p->p_cpticks = 0;
-               a = (int) get_pcpu(b, p->p_cpu) + p->p_nice;
-               if (a < 0)
-                       a = 0;
-               if (a > 255)
-                       a = 255;
-               p->p_cpu = a;
-               (void) setpri(p);
+               newcpu = (u_int) decay_cpu(loadfac, p->p_cpu) + p->p_nice;
+               p->p_cpu = min(newcpu, UCHAR_MAX);
+               setpri(p);
                s = splhigh();  /* prevent state changes */
                if (p->p_pri >= PUSER) {
                s = splhigh();  /* prevent state changes */
                if (p->p_pri >= PUSER) {
-#define        PPQ     (128 / NQS)
-                       if ((p != u.u_procp || noproc) &&
+#define        PPQ     (128 / NQS)             /* priorities per queue */
+                       if ((p != curproc) &&
                            p->p_stat == SRUN &&
                            (p->p_flag & SLOAD) &&
                            (p->p_pri / PPQ) != (p->p_usrpri / PPQ)) {
                            p->p_stat == SRUN &&
                            (p->p_flag & SLOAD) &&
                            (p->p_pri / PPQ) != (p->p_usrpri / PPQ)) {
@@ -173,34 +185,32 @@ schedcpu()
                splx(s);
        }
        vmmeter();
                splx(s);
        }
        vmmeter();
-       if (runin!=0) {
-               runin = 0;
-               wakeup((caddr_t)&runin);
-       }
        if (bclnlist != NULL)
        if (bclnlist != NULL)
-               wakeup((caddr_t)&proc[2]);
-       timeout(schedcpu, (caddr_t)0, hz);
+               wakeup((caddr_t)pageproc);
+       timeout(schedcpu, (void *)0, hz);
 }
 
 /*
  * Recalculate the priority of a process after it has slept for a while.
 }
 
 /*
  * Recalculate the priority of a process after it has slept for a while.
+ * For all load averages >= 1 and max p_cpu of 255, sleeping for at least
+ * six times the loadfactor will decay p_cpu to zero.
  */
  */
+void
 updatepri(p)
        register struct proc *p;
 {
 updatepri(p)
        register struct proc *p;
 {
-       register int a = p->p_cpu & 0377;
-       register fixpt_t b = get_b(averunnable[0]);
-
-       p->p_slptime--;         /* the first time was done in schedcpu */
-       while (a && --p->p_slptime)
-               a = (int) get_pcpu(b, a) /* + p->p_nice */;
-       p->p_slptime = 0;
-       if (a < 0)
-               a = 0;
-       if (a > 255)
-               a = 255;
-       p->p_cpu = a;
-       (void) setpri(p);
+       register unsigned int newcpu = p->p_cpu;
+       register fixpt_t loadfac = loadfactor(averunnable.ldavg[0]);
+
+       if (p->p_slptime > 5 * loadfac)
+               p->p_cpu = 0;
+       else {
+               p->p_slptime--; /* the first time was done in schedcpu */
+               while (newcpu && --p->p_slptime)
+                       newcpu = (int) decay_cpu(loadfac, newcpu);
+               p->p_cpu = min(newcpu, UCHAR_MAX);
+       }
+       setpri(p);
 }
 
 #define SQSIZE 0100    /* Must be power of 2 */
 }
 
 #define SQSIZE 0100    /* Must be power of 2 */
@@ -234,20 +244,24 @@ int safepri;
  * if possible, and EINTR is returned if the system call should
  * be interrupted by the signal (return EINTR).
  */
  * if possible, and EINTR is returned if the system call should
  * be interrupted by the signal (return EINTR).
  */
+int
 tsleep(chan, pri, wmesg, timo)
 tsleep(chan, pri, wmesg, timo)
-       caddr_t chan;
+       void *chan;
        int pri;
        char *wmesg;
        int timo;
 {
        int pri;
        char *wmesg;
        int timo;
 {
-       register struct proc *rp;
+       register struct proc *p = curproc;
        register struct slpque *qp;
        register s;
        int sig, catch = pri & PCATCH;
        extern int cold;
        register struct slpque *qp;
        register s;
        int sig, catch = pri & PCATCH;
        extern int cold;
-       int endtsleep();
+       void endtsleep __P((void *));
 
 
-       rp = u.u_procp;
+#ifdef KTRACE
+       if (KTRPOINT(p, KTR_CSW))
+               ktrcsw(p->p_tracep, 1, 0);
+#endif
        s = splhigh();
        if (cold || panicstr) {
                /*
        s = splhigh();
        if (cold || panicstr) {
                /*
@@ -261,61 +275,75 @@ tsleep(chan, pri, wmesg, timo)
                return (0);
        }
 #ifdef DIAGNOSTIC
                return (0);
        }
 #ifdef DIAGNOSTIC
-       if (chan == 0 || rp->p_stat != SRUN || rp->p_rlink)
+       if (chan == NULL || p->p_stat != SRUN || p->p_rlink)
                panic("tsleep");
 #endif
                panic("tsleep");
 #endif
-       rp->p_wchan = chan;
-       rp->p_wmesg = wmesg;
-       rp->p_slptime = 0;
-       rp->p_pri = pri & PRIMASK;
+       p->p_wchan = chan;
+       p->p_wmesg = wmesg;
+       p->p_slptime = 0;
+       p->p_pri = pri & PRIMASK;
        qp = &slpque[HASH(chan)];
        if (qp->sq_head == 0)
        qp = &slpque[HASH(chan)];
        if (qp->sq_head == 0)
-               qp->sq_head = rp;
+               qp->sq_head = p;
        else
        else
-               *qp->sq_tailp = rp;
-       *(qp->sq_tailp = &rp->p_link) = 0;
+               *qp->sq_tailp = p;
+       *(qp->sq_tailp = &p->p_link) = 0;
        if (timo)
        if (timo)
-               timeout(endtsleep, (caddr_t)rp, timo);
+               timeout(endtsleep, (void *)p, timo);
        /*
        /*
-        * If we stop in CURSIG/issig(), a wakeup or a SIGCONT
-        * (or both) could occur while we were stopped.
+        * We put ourselves on the sleep queue and start our timeout
+        * before calling CURSIG, as we could stop there, and a wakeup
+        * or a SIGCONT (or both) could occur while we were stopped.
         * A SIGCONT would cause us to be marked as SSLEEP
         * without resuming us, thus we must be ready for sleep
         * when CURSIG is called.  If the wakeup happens while we're
         * A SIGCONT would cause us to be marked as SSLEEP
         * without resuming us, thus we must be ready for sleep
         * when CURSIG is called.  If the wakeup happens while we're
-        * stopped, rp->p_wchan will be 0 upon return from CURSIG.
+        * stopped, p->p_wchan will be 0 upon return from CURSIG.
         */
        if (catch) {
         */
        if (catch) {
-               rp->p_flag |= SSINTR;
-               if (sig = CURSIG(rp)) {
-                       if (rp->p_wchan)
-                               unsleep(rp);
-                       rp->p_stat = SRUN;
+               p->p_flag |= SSINTR;
+               if (sig = CURSIG(p)) {
+                       if (p->p_wchan)
+                               unsleep(p);
+                       p->p_stat = SRUN;
                        goto resume;
                }
                        goto resume;
                }
-               if (rp->p_wchan == 0) {
+               if (p->p_wchan == 0) {
                        catch = 0;
                        goto resume;
                }
                        catch = 0;
                        goto resume;
                }
-       }
-       rp->p_stat = SSLEEP;
-       (void) spl0();
-       u.u_ru.ru_nvcsw++;
+       } else
+               sig = 0;
+       p->p_stat = SSLEEP;
+       p->p_stats->p_ru.ru_nvcsw++;
        swtch();
 resume:
        swtch();
 resume:
-       curpri = rp->p_usrpri;
+       curpri = p->p_usrpri;
        splx(s);
        splx(s);
-       rp->p_flag &= ~SSINTR;
-       if (rp->p_flag & STIMO) {
-               rp->p_flag &= ~STIMO;
-               if (catch == 0 || sig == 0)
+       p->p_flag &= ~SSINTR;
+       if (p->p_flag & STIMO) {
+               p->p_flag &= ~STIMO;
+               if (sig == 0) {
+#ifdef KTRACE
+                       if (KTRPOINT(p, KTR_CSW))
+                               ktrcsw(p->p_tracep, 0, 0);
+#endif
                        return (EWOULDBLOCK);
                        return (EWOULDBLOCK);
+               }
        } else if (timo)
        } else if (timo)
-               untimeout(endtsleep, (caddr_t)rp);
-       if (catch && (sig != 0 || (sig = CURSIG(rp)))) {
-               if (u.u_sigintr & sigmask(sig))
+               untimeout(endtsleep, (void *)p);
+       if (catch && (sig != 0 || (sig = CURSIG(p)))) {
+#ifdef KTRACE
+               if (KTRPOINT(p, KTR_CSW))
+                       ktrcsw(p->p_tracep, 0, 0);
+#endif
+               if (p->p_sigacts->ps_sigintr & sigmask(sig))
                        return (EINTR);
                return (ERESTART);
        }
                        return (EINTR);
                return (ERESTART);
        }
+#ifdef KTRACE
+       if (KTRPOINT(p, KTR_CSW))
+               ktrcsw(p->p_tracep, 0, 0);
+#endif
        return (0);
 }
 
        return (0);
 }
 
@@ -325,11 +353,15 @@ resume:
  * set timeout flag and undo the sleep.  If proc
  * is stopped, just unsleep so it will remain stopped.
  */
  * set timeout flag and undo the sleep.  If proc
  * is stopped, just unsleep so it will remain stopped.
  */
-endtsleep(p)
-       register struct proc *p;
+void
+endtsleep(arg)
+       void *arg;
 {
 {
-       int s = splhigh();
+       register struct proc *p;
+       int s;
 
 
+       p = (struct proc *)arg;
+       s = splhigh();
        if (p->p_wchan) {
                if (p->p_stat == SSLEEP)
                        setrun(p);
        if (p->p_wchan) {
                if (p->p_stat == SSLEEP)
                        setrun(p);
@@ -343,11 +375,12 @@ endtsleep(p)
 /*
  * Short-term, non-interruptable sleep.
  */
 /*
  * Short-term, non-interruptable sleep.
  */
+void
 sleep(chan, pri)
 sleep(chan, pri)
-       caddr_t chan;
+       void *chan;
        int pri;
 {
        int pri;
 {
-       register struct proc *rp;
+       register struct proc *p = curproc;
        register struct slpque *qp;
        register s;
        extern int cold;
        register struct slpque *qp;
        register s;
        extern int cold;
@@ -355,11 +388,10 @@ sleep(chan, pri)
 #ifdef DIAGNOSTIC
        if (pri > PZERO) {
                printf("sleep called with pri %d > PZERO, wchan: %x\n",
 #ifdef DIAGNOSTIC
        if (pri > PZERO) {
                printf("sleep called with pri %d > PZERO, wchan: %x\n",
-                       pri, chan);
+                   pri, chan);
                panic("old sleep");
        }
 #endif
                panic("old sleep");
        }
 #endif
-       rp = u.u_procp;
        s = splhigh();
        if (cold || panicstr) {
                /*
        s = splhigh();
        if (cold || panicstr) {
                /*
@@ -373,30 +405,38 @@ sleep(chan, pri)
                return;
        }
 #ifdef DIAGNOSTIC
                return;
        }
 #ifdef DIAGNOSTIC
-       if (chan==0 || rp->p_stat != SRUN || rp->p_rlink)
+       if (chan == NULL || p->p_stat != SRUN || p->p_rlink)
                panic("sleep");
 #endif
                panic("sleep");
 #endif
-       rp->p_wchan = chan;
-       rp->p_wmesg = NULL;
-       rp->p_slptime = 0;
-       rp->p_pri = pri;
+       p->p_wchan = chan;
+       p->p_wmesg = NULL;
+       p->p_slptime = 0;
+       p->p_pri = pri;
        qp = &slpque[HASH(chan)];
        if (qp->sq_head == 0)
        qp = &slpque[HASH(chan)];
        if (qp->sq_head == 0)
-               qp->sq_head = rp;
+               qp->sq_head = p;
        else
        else
-               *qp->sq_tailp = rp;
-       *(qp->sq_tailp = &rp->p_link) = 0;
-       rp->p_stat = SSLEEP;
-       (void) spl0();
-       u.u_ru.ru_nvcsw++;
+               *qp->sq_tailp = p;
+       *(qp->sq_tailp = &p->p_link) = 0;
+       p->p_stat = SSLEEP;
+       p->p_stats->p_ru.ru_nvcsw++;
+#ifdef KTRACE
+       if (KTRPOINT(p, KTR_CSW))
+               ktrcsw(p->p_tracep, 1, 0);
+#endif
        swtch();
        swtch();
-       curpri = rp->p_usrpri;
+#ifdef KTRACE
+       if (KTRPOINT(p, KTR_CSW))
+               ktrcsw(p->p_tracep, 0, 0);
+#endif
+       curpri = p->p_usrpri;
        splx(s);
 }
 
 /*
  * Remove a process from its wait queue
  */
        splx(s);
 }
 
 /*
  * Remove a process from its wait queue
  */
+void
 unsleep(p)
        register struct proc *p;
 {
 unsleep(p)
        register struct proc *p;
 {
@@ -418,10 +458,12 @@ unsleep(p)
 }
 
 /*
 }
 
 /*
- * Wake up all processes sleeping on chan.
+ * Wakeup on "chan"; set all processes
+ * sleeping on chan to run state.
  */
  */
+void
 wakeup(chan)
 wakeup(chan)
-       register caddr_t chan;
+       register void *chan;
 {
        register struct slpque *qp;
        register struct proc *p, **q;
 {
        register struct slpque *qp;
        register struct proc *p, **q;
@@ -435,7 +477,7 @@ restart:
                if (p->p_rlink || p->p_stat != SSLEEP && p->p_stat != SSTOP)
                        panic("wakeup");
 #endif
                if (p->p_rlink || p->p_stat != SSLEEP && p->p_stat != SSTOP)
                        panic("wakeup");
 #endif
-               if (p->p_wchan==chan) {
+               if (p->p_wchan == chan) {
                        p->p_wchan = 0;
                        *q = p->p_link;
                        if (qp->sq_tailp == &p->p_link)
                        p->p_wchan = 0;
                        *q = p->p_link;
                        if (qp->sq_tailp == &p->p_link)
@@ -444,6 +486,7 @@ restart:
                                /* OPTIMIZED INLINE EXPANSION OF setrun(p) */
                                if (p->p_slptime > 1)
                                        updatepri(p);
                                /* OPTIMIZED INLINE EXPANSION OF setrun(p) */
                                if (p->p_slptime > 1)
                                        updatepri(p);
+                               p->p_slptime = 0;
                                p->p_stat = SRUN;
                                if (p->p_flag & SLOAD)
                                        setrq(p);
                                p->p_stat = SRUN;
                                if (p->p_flag & SLOAD)
                                        setrq(p);
@@ -451,15 +494,10 @@ restart:
                                 * Since curpri is a usrpri,
                                 * p->p_pri is always better than curpri.
                                 */
                                 * Since curpri is a usrpri,
                                 * p->p_pri is always better than curpri.
                                 */
-                               runrun++;
-                               aston();
-                               if ((p->p_flag&SLOAD) == 0) {
-                                       if (runout != 0) {
-                                               runout = 0;
-                                               wakeup((caddr_t)&runout);
-                                       }
-                                       wantin++;
-                               }
+                               if ((p->p_flag&SLOAD) == 0)
+                                       wakeup((caddr_t)&proc0);
+                               else
+                                       need_resched();
                                /* END INLINE EXPANSION */
                                goto restart;
                        }
                                /* END INLINE EXPANSION */
                                goto restart;
                        }
@@ -469,6 +507,63 @@ restart:
        splx(s);
 }
 
        splx(s);
 }
 
+/*
+ * The machine independent parts of swtch().
+ * Must be called at splstatclock() or higher.
+ */
+void
+swtch()
+{
+       register struct proc *p = curproc;      /* XXX */
+       register struct rlimit *rlim;
+       register long s, u;
+       struct timeval tv;
+
+       /*
+        * Compute the amount of time during which the current
+        * process was running, and add that to its total so far.
+        */
+       microtime(&tv);
+       u = p->p_rtime.tv_usec + (tv.tv_usec - runtime.tv_usec);
+       s = p->p_rtime.tv_sec + (tv.tv_sec - runtime.tv_sec);
+       if (u < 0) {
+               u += 1000000;
+               s--;
+       } else if (u >= 1000000) {
+               u -= 1000000;
+               s++;
+       }
+       p->p_rtime.tv_usec = u;
+       p->p_rtime.tv_sec = s;
+
+       /*
+        * Check if the process exceeds its cpu resource allocation.
+        * If over max, kill it.  In any case, if it has run for more
+        * than 10 minutes, reduce priority to give others a chance.
+        */
+       rlim = &p->p_rlimit[RLIMIT_CPU];
+       if (s >= rlim->rlim_cur) {
+               if (s >= rlim->rlim_max)
+                       psignal(p, SIGKILL);
+               else {
+                       psignal(p, SIGXCPU);
+                       if (rlim->rlim_cur < rlim->rlim_max)
+                               rlim->rlim_cur += 5;
+               }
+       }
+       if (s > 10 * 60 && p->p_ucred->cr_uid && p->p_nice == NZERO) {
+               p->p_nice = NZERO + 4;
+               setpri(p);
+       }
+
+       /*
+        * Pick a new current process and record its start time.
+        */
+       cnt.v_swtch++;
+       cpu_swtch(p);
+       microtime(&runtime);
+}
+
 /*
  * Initialize the (doubly-linked) run queues
  * to be empty.
 /*
  * Initialize the (doubly-linked) run queues
  * to be empty.
@@ -482,9 +577,11 @@ rqinit()
 }
 
 /*
 }
 
 /*
- * Set the process running;
- * arrange for it to be swapped in if necessary.
+ * Change process state to be runnable,
+ * placing it on the run queue if it is in memory,
+ * and awakening the swapper if it isn't in memory.
  */
  */
+void
 setrun(p)
        register struct proc *p;
 {
 setrun(p)
        register struct proc *p;
 {
@@ -514,40 +611,27 @@ setrun(p)
        splx(s);
        if (p->p_slptime > 1)
                updatepri(p);
        splx(s);
        if (p->p_slptime > 1)
                updatepri(p);
-       if (p->p_pri < curpri) {
-               runrun++;
-               aston();
-       }
-       if ((p->p_flag&SLOAD) == 0) {
-               if (runout != 0) {
-                       runout = 0;
-                       wakeup((caddr_t)&runout);
-               }
-               wantin++;
-       }
+       p->p_slptime = 0;
+       if ((p->p_flag&SLOAD) == 0)
+               wakeup((caddr_t)&proc0);
+       else if (p->p_pri < curpri)
+               need_resched();
 }
 
 /*
 }
 
 /*
- * Set user priority.
- * The rescheduling flag (runrun)
- * is set if the priority is better
- * than the currently running process.
+ * Compute priority of process when running in user mode.
+ * Arrange to reschedule if the resulting priority
+ * is better than that of the current process.
  */
  */
-setpri(pp)
-       register struct proc *pp;
+void
+setpri(p)
+       register struct proc *p;
 {
 {
-       register int p;
-
-       p = (pp->p_cpu & 0377)/4;
-       p += PUSER + 2 * pp->p_nice;
-       if (pp->p_rssize > pp->p_maxrss && freemem < desfree)
-               p += 2*4;       /* effectively, nice(4) */
-       if (p > 127)
-               p = 127;
-       if (p < curpri) {
-               runrun++;
-               aston();
-       }
-       pp->p_usrpri = p;
-       return (p);
+       register unsigned int newpri;
+
+       newpri = PUSER + p->p_cpu / 4 + 2 * p->p_nice;
+       newpri = min(newpri, MAXPRI);
+       p->p_usrpri = newpri;
+       if (newpri < curpri)
+               need_resched();
 }
 }